From 5b899e99fe25f3edba1fdba2b6686a9aa8c56b6b Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Tue, 4 May 2021 23:19:29 +0200 Subject: [PATCH] bgpd: changing graceful-restart parameters should not be considered as error vtysh will return an informational message to the user that changing any graceful-shutdown related parameter will require a peer reset. This is should not be treated as an error message (resulting in a return code of 1) but rather as a simple information to the user. This fixes GitHub issue https://github.com/FRRouting/frr/issues/8403 $ vtysh -c configure -c 'router bgp 100' -c 'bgp graceful-restart' Graceful restart configuration changed, reset all peers to take effect $ echo $? 0 Signed-off-by: Christian Poessinger --- bgpd/bgp_vty.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c index 1e465d2620..78f3ccf6fa 100644 --- a/bgpd/bgp_vty.c +++ b/bgpd/bgp_vty.c @@ -840,9 +840,6 @@ int bgp_vty_return(struct vty *vty, int ret) case BGP_ERR_GR_OPERATION_FAILED: str = "The Graceful Restart Operation failed due to an err."; break; - case BGP_GR_NO_OPERATION: - str = GR_NO_OPER; - break; } if (str) { vty_out(vty, "%% %s\n", str);