zebra: fix SA warning, handle return code

Handle a return code, resolving an SA warning

Signed-off-by: Mark Stapp <mjs@voltanet.io>
This commit is contained in:
Mark Stapp 2020-07-28 08:30:52 -04:00
parent dca30d85fb
commit 54d321aaa3

View File

@ -2490,7 +2490,8 @@ dplane_route_notif_update(struct route_node *rn,
enum dplane_op_e op, enum dplane_op_e op,
struct zebra_dplane_ctx *ctx) struct zebra_dplane_ctx *ctx)
{ {
enum zebra_dplane_result ret = ZEBRA_DPLANE_REQUEST_FAILURE; enum zebra_dplane_result result = ZEBRA_DPLANE_REQUEST_FAILURE;
int ret = EINVAL;
struct zebra_dplane_ctx *new_ctx = NULL; struct zebra_dplane_ctx *new_ctx = NULL;
struct nexthop *nexthop; struct nexthop *nexthop;
struct nexthop_group *nhg; struct nexthop_group *nhg;
@ -2536,12 +2537,15 @@ dplane_route_notif_update(struct route_node *rn,
dplane_ctx_set_notif_provider(new_ctx, dplane_ctx_set_notif_provider(new_ctx,
dplane_ctx_get_notif_provider(ctx)); dplane_ctx_get_notif_provider(ctx));
dplane_update_enqueue(new_ctx); ret = dplane_update_enqueue(new_ctx);
ret = ZEBRA_DPLANE_REQUEST_QUEUED;
done: done:
return ret; if (ret == AOK)
result = ZEBRA_DPLANE_REQUEST_QUEUED;
else if (ctx)
dplane_ctx_free(&ctx);
return result;
} }
/* /*