proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 23:54:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: guard strict cli completions

Browse Source 
Completions are checked for token and docstring equality before
deduplicating. Put an ifdef guard around checking docstrings because
many of them are inconsistent and may confuse users in a release build.

It is a good idea to enable VTYSH_DEBUG when adding new CLI in the
future to help check docstrings.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
This commit is contained in:
Quentin Young 2017-01-19 17:07:39 +00:00
parent 45680e7568
commit 5320569435
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/command.c
View File

@ -541,8 +541,12 @@ completions_to_vec (struct list *completions)
for (i = 0; i < vector_active (comps) && !exists; i++) for (i = 0; i < vector_active (comps) && !exists; i++)
{ {
struct cmd_token *curr = vector_slot (comps, i); struct cmd_token *curr = vector_slot (comps, i);
#ifdef VTYSH_DEBUG
exists = !strcmp (curr->text, token->text) && exists = !strcmp (curr->text, token->text) &&
!strcmp (curr->desc, token->desc); !strcmp (curr->desc, token->desc);
#else
exists = !strcmp (curr->text, token->text);
#endif /* VTYSH_DEBUG */
} }
if (!exists) if (!exists)