proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-08 12:49:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #5152 from donaldsharp/evpn_es_not_locking

Browse Source 
Some bgp evpn fixes
This commit is contained in:
Russ White 2019-10-15 11:09:12 -04:00 committed by GitHub
commit 51de65305d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
bgpd/bgp_evpn.c
View File

@ -2394,6 +2394,30 @@ static int handle_tunnel_ip_change(struct bgp *bgp, struct bgpevpn *vpn,
return 0; return 0;
} }
static void bgp_create_evpn_bgp_path_info(struct bgp_path_info *parent_pi,
struct bgp_node *rn)
{
struct attr *attr_new;
struct bgp_path_info *pi;
/* Add (or update) attribute to hash. */
attr_new = bgp_attr_intern(parent_pi->attr);
/* Create new route with its attribute. */
pi = info_make(parent_pi->type, BGP_ROUTE_IMPORTED, 0, parent_pi->peer,
attr_new, rn);
SET_FLAG(pi->flags, BGP_PATH_VALID);
bgp_path_info_extra_get(pi);
pi->extra->parent = bgp_path_info_lock(parent_pi);
bgp_lock_node((struct bgp_node *)parent_pi->net);
if (parent_pi->extra) {
memcpy(&pi->extra->label, &parent_pi->extra->label,
sizeof(pi->extra->label));
pi->extra->num_labels = parent_pi->extra->num_labels;
}
bgp_path_info_add(rn, pi);
}
/* Install EVPN route entry in ES */ /* Install EVPN route entry in ES */
static int install_evpn_route_entry_in_es(struct bgp *bgp, struct evpnes *es, static int install_evpn_route_entry_in_es(struct bgp *bgp, struct evpnes *es,
struct prefix_evpn *p, struct prefix_evpn *p,
@ -2424,7 +2448,8 @@ static int install_evpn_route_entry_in_es(struct bgp *bgp, struct evpnes *es,
parent_pi->peer, attr_new, rn); parent_pi->peer, attr_new, rn);
SET_FLAG(pi->flags, BGP_PATH_VALID); SET_FLAG(pi->flags, BGP_PATH_VALID);
bgp_path_info_extra_get(pi); bgp_path_info_extra_get(pi);
pi->extra->parent = parent_pi; pi->extra->parent = bgp_path_info_lock(parent_pi);
bgp_lock_node((struct bgp_node *)parent_pi->net);
bgp_path_info_add(rn, pi); bgp_path_info_add(rn, pi);
} else { } else {
if (attrhash_cmp(pi->attr, parent_pi->attr) if (attrhash_cmp(pi->attr, parent_pi->attr)
@ -2516,24 +2541,9 @@ static int install_evpn_route_entry_in_vrf(struct bgp *bgp_vrf,
&& (struct bgp_path_info *)pi->extra->parent == parent_pi) && (struct bgp_path_info *)pi->extra->parent == parent_pi)
break; break;
if (!pi) { if (!pi)
/* Add (or update) attribute to hash. */ bgp_create_evpn_bgp_path_info(parent_pi, rn);
attr_new = bgp_attr_intern(&attr); else {
/* Create new route with its attribute. */
pi = info_make(parent_pi->type, BGP_ROUTE_IMPORTED, 0,
parent_pi->peer, attr_new, rn);
SET_FLAG(pi->flags, BGP_PATH_VALID);
bgp_path_info_extra_get(pi);
pi->extra->parent = bgp_path_info_lock(parent_pi);
bgp_lock_node((struct bgp_node *)parent_pi->net);
if (parent_pi->extra) {
memcpy(&pi->extra->label, &parent_pi->extra->label,
sizeof(pi->extra->label));
pi->extra->num_labels = parent_pi->extra->num_labels;
}
bgp_path_info_add(rn, pi);
} else {
if (attrhash_cmp(pi->attr, &attr) if (attrhash_cmp(pi->attr, &attr)
&& !CHECK_FLAG(pi->flags, BGP_PATH_REMOVED)) { && !CHECK_FLAG(pi->flags, BGP_PATH_REMOVED)) {
bgp_unlock_node(rn); bgp_unlock_node(rn);
@ -2595,24 +2605,9 @@ static int install_evpn_route_entry(struct bgp *bgp, struct bgpevpn *vpn,
&& (struct bgp_path_info *)pi->extra->parent == parent_pi) && (struct bgp_path_info *)pi->extra->parent == parent_pi)
break; break;
if (!pi) { if (!pi)
/* Add (or update) attribute to hash. */ bgp_create_evpn_bgp_path_info(parent_pi, rn);
attr_new = bgp_attr_intern(parent_pi->attr); else {
/* Create new route with its attribute. */
pi = info_make(parent_pi->type, BGP_ROUTE_IMPORTED, 0,
parent_pi->peer, attr_new, rn);
SET_FLAG(pi->flags, BGP_PATH_VALID);
bgp_path_info_extra_get(pi);
pi->extra->parent = bgp_path_info_lock(parent_pi);
bgp_lock_node((struct bgp_node *)parent_pi->net);
if (parent_pi->extra) {
memcpy(&pi->extra->label, &parent_pi->extra->label,
sizeof(pi->extra->label));
pi->extra->num_labels = parent_pi->extra->num_labels;
}
bgp_path_info_add(rn, pi);
} else {
if (attrhash_cmp(pi->attr, parent_pi->attr) if (attrhash_cmp(pi->attr, parent_pi->attr)
&& !CHECK_FLAG(pi->flags, BGP_PATH_REMOVED)) { && !CHECK_FLAG(pi->flags, BGP_PATH_REMOVED)) {
bgp_unlock_node(rn); bgp_unlock_node(rn);

2
bgpd/bgp_route.c
View File

@ -8967,7 +8967,7 @@ void route_vty_out_detail(struct vty *vty, struct bgp *bgp,
/* Remote Label */ /* Remote Label */
if (path->extra && bgp_is_valid_label(&path->extra->label[0]) if (path->extra && bgp_is_valid_label(&path->extra->label[0])
&& safi != SAFI_EVPN) { && (safi != SAFI_EVPN && !is_route_parent_evpn(path))) {
mpls_label_t label = label_pton(&path->extra->label[0]); mpls_label_t label = label_pton(&path->extra->label[0]);
if (json_paths) if (json_paths)