proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-09 23:48:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Fix usage of uninitialized dn_flag[]

Browse Source 
dn_flag was tested inside of a 'use_json' block
further down in the function.  Move initialization
of the value to outside of the !use_json if statement

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2017-02-07 14:55:39 -05:00
parent bf97380cf1
commit 517cd68a3e
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bgpd/bgp_vty.c
View File

@ -7337,6 +7337,10 @@ bgp_show_peer (struct vty *vty, struct peer *p, u_char use_json, json_object *js
if (use_json) if (use_json)
json_neigh = json_object_new_object(); json_neigh = json_object_new_object();
memset (dn_flag, '\0', sizeof (dn_flag));
if (!p->conf_if && peer_dynamic_neighbor (p))
dn_flag[0] = '*';
if (!use_json) if (!use_json)
{ {
if (p->conf_if) /* Configured interface name. */ if (p->conf_if) /* Configured interface name. */
@ -7344,13 +7348,7 @@ bgp_show_peer (struct vty *vty, struct peer *p, u_char use_json, json_object *js
BGP_PEER_SU_UNSPEC(p) ? "None" : BGP_PEER_SU_UNSPEC(p) ? "None" :
sockunion2str (&p->su, buf, SU_ADDRSTRLEN)); sockunion2str (&p->su, buf, SU_ADDRSTRLEN));
else /* Configured IP address. */ else /* Configured IP address. */
{
memset(dn_flag, '\0', sizeof(dn_flag));
if (peer_dynamic_neighbor(p))
dn_flag[0] = '*';
vty_out (vty, "BGP neighbor is %s%s, ", dn_flag, p->host); vty_out (vty, "BGP neighbor is %s%s, ", dn_flag, p->host);
}
} }
if (use_json) if (use_json)