proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-07 15:30:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ospfclient: Free up leaked resources in error path

Browse Source 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2017-06-13 13:15:01 -04:00
parent e6fda497d3
commit 5125997a8a
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ospfclient/ospf_apiclient.c
View File

@ -183,6 +183,7 @@ ospf_apiclient_connect (char *host, int syncport)
fd1 = socket (AF_INET, SOCK_STREAM, 0); fd1 = socket (AF_INET, SOCK_STREAM, 0);
if (fd1 < 0) if (fd1 < 0)
{ {
close (async_server_sock);
fprintf (stderr, fprintf (stderr,
"ospf_apiclient_connect: creating sync socket failed\n"); "ospf_apiclient_connect: creating sync socket failed\n");
return NULL; return NULL;
@ -196,6 +197,7 @@ ospf_apiclient_connect (char *host, int syncport)
{ {
fprintf (stderr, "ospf_apiclient_connect: SO_REUSEADDR failed\n"); fprintf (stderr, "ospf_apiclient_connect: SO_REUSEADDR failed\n");
close (fd1); close (fd1);
close (async_server_sock);
return NULL; return NULL;
} }
@ -206,6 +208,7 @@ ospf_apiclient_connect (char *host, int syncport)
{ {
fprintf (stderr, "ospf_apiclient_connect: SO_REUSEPORT failed\n"); fprintf (stderr, "ospf_apiclient_connect: SO_REUSEPORT failed\n");
close (fd1); close (fd1);
close (async_server_sock);
return NULL; return NULL;
} }
#endif /* SO_REUSEPORT */ #endif /* SO_REUSEPORT */
@ -227,6 +230,7 @@ ospf_apiclient_connect (char *host, int syncport)
{ {
fprintf (stderr, "ospf_apiclient_connect: bind sync socket failed\n"); fprintf (stderr, "ospf_apiclient_connect: bind sync socket failed\n");
close (fd1); close (fd1);
close (async_server_sock);
return NULL; return NULL;
} }
@ -260,6 +264,7 @@ ospf_apiclient_connect (char *host, int syncport)
fprintf (stderr, "ospf_apiclient_connect: accept async failed\n"); fprintf (stderr, "ospf_apiclient_connect: accept async failed\n");
close (async_server_sock); close (async_server_sock);
close (fd1); close (fd1);
close (fd2);
return NULL; return NULL;
} }