proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-02 00:48:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6943 from ton31337/fix/replace_sizeof_instead_of_constant_for_bgp_dump_attr

Browse Source 
bgpd: Use sizeof() in bgp_dump_attr()
This commit is contained in:
Renato Westphal 2020-08-19 07:36:13 -03:00 committed by GitHub
commit 4fe5bc8c62
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bgpd/bgp_evpn.c
View File

@ -2836,7 +2836,7 @@ static int bgp_evpn_route_rmac_self_check(struct bgp *bgp_vrf,
char buf1[PREFIX_STRLEN]; char buf1[PREFIX_STRLEN];
char attr_str[BUFSIZ] = {0}; char attr_str[BUFSIZ] = {0};
bgp_dump_attr(pi->attr, attr_str, BUFSIZ); bgp_dump_attr(pi->attr, attr_str, sizeof(attr_str));
zlog_debug("%s: bgp %u prefix %s with attr %s - DENIED due to self mac", zlog_debug("%s: bgp %u prefix %s with attr %s - DENIED due to self mac",
__func__, bgp_vrf->vrf_id, __func__, bgp_vrf->vrf_id,
@ -5190,7 +5190,8 @@ int bgp_filter_evpn_routes_upon_martian_nh_change(struct bgp *bgp)
char attr_str[BUFSIZ] = {0}; char attr_str[BUFSIZ] = {0};
bgp_dump_attr(pi->attr, bgp_dump_attr(pi->attr,
attr_str, BUFSIZ); attr_str,
sizeof(attr_str));
zlog_debug( zlog_debug(
"%u: prefix %pRN with attr %s - DENIED due to martian or self nexthop", "%u: prefix %pRN with attr %s - DENIED due to martian or self nexthop",

3
bgpd/bgp_packet.c
View File

@ -1573,7 +1573,8 @@ static int bgp_update_receive(struct peer *peer, bgp_size_t size)
if (attr_parse_ret == BGP_ATTR_PARSE_WITHDRAW if (attr_parse_ret == BGP_ATTR_PARSE_WITHDRAW
|| BGP_DEBUG(update, UPDATE_IN) || BGP_DEBUG(update, UPDATE_IN)
|| BGP_DEBUG(update, UPDATE_PREFIX)) { || BGP_DEBUG(update, UPDATE_PREFIX)) {
ret = bgp_dump_attr(&attr, peer->rcvd_attr_str, BUFSIZ); ret = bgp_dump_attr(&attr, peer->rcvd_attr_str,
sizeof(peer->rcvd_attr_str));
peer->stat_upd_7606++; peer->stat_upd_7606++;

4
bgpd/bgp_updgrp_packet.c
View File

@ -837,7 +837,7 @@ struct bpacket *subgroup_update_packet(struct update_subgroup *subgrp)
memset(send_attr_str, 0, BUFSIZ); memset(send_attr_str, 0, BUFSIZ);
send_attr_printed = 0; send_attr_printed = 0;
bgp_dump_attr(adv->baa->attr, send_attr_str, bgp_dump_attr(adv->baa->attr, send_attr_str,
BUFSIZ); sizeof(send_attr_str));
} }
} }
@ -1147,7 +1147,7 @@ void subgroup_default_update_packet(struct update_subgroup *subgrp,
attrstr[0] = '\0'; attrstr[0] = '\0';
bgp_dump_attr(attr, attrstr, BUFSIZ); bgp_dump_attr(attr, attrstr, sizeof(attrstr));
if (addpath_encode) if (addpath_encode)
snprintf(tx_id_buf, sizeof(tx_id_buf), snprintf(tx_id_buf, sizeof(tx_id_buf),