proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-02 16:57:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: BFD integration clean up function

Browse Source 
Implement clean up function to be called on shutdown to make daemon exit
clean for valgrind and other memory sanitizers.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
This commit is contained in:
Rafael Zalamena 2022-12-02 10:04:40 -03:00
parent b7ca809d1c
commit 4e35b32ee5
1 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
lib/bfd.c
View File

@ -29,6 +29,7 @@
#include "stream.h" #include "stream.h"
#include "vrf.h" #include "vrf.h"
#include "zclient.h" #include "zclient.h"
#include "libfrr.h"
#include "table.h" #include "table.h"
#include "vty.h" #include "vty.h"
#include "bfd.h" #include "bfd.h"
@ -1045,6 +1046,40 @@ int zclient_bfd_session_update(ZAPI_CALLBACK_ARGS)
return 0; return 0;
} }
/**
* Frees all allocated resources and stops any activity.
*
* Must be called after every BFD session has been successfully
* unconfigured otherwise this function will `free()` any available
* session causing existing pointers to dangle.
*
* This is just a comment, in practice it will be called by the FRR
* library late finish hook. \see `bfd_protocol_integration_init`.
*/
static int bfd_protocol_integration_finish(void)
{
if (bsglobal.zc == NULL)
return 0;
while (!TAILQ_EMPTY(&bsglobal.bsplist)) {
struct bfd_session_params *session =
TAILQ_FIRST(&bsglobal.bsplist);
bfd_sess_free(&session);
}
/*
* BFD source cache is linked to sessions, if all sessions are gone
* then the source cache must be empty.
*/
if (!SLIST_EMPTY(&bsglobal.source_list))
zlog_warn("BFD integration source cache not empty");
zclient_stop(bsglobal.nht_zclient);
zclient_free(bsglobal.nht_zclient);
return 0;
}
static zclient_handler *const bfd_nht_handlers[] = { static zclient_handler *const bfd_nht_handlers[] = {
[ZEBRA_NEXTHOP_UPDATE] = bfd_nht_update, [ZEBRA_NEXTHOP_UPDATE] = bfd_nht_update,
}; };
@ -1076,6 +1111,8 @@ void bfd_protocol_integration_init(struct zclient *zc, struct thread_master *tm)
bsglobal.nht_zclient->zebra_connected = bfd_nht_zclient_connected; bsglobal.nht_zclient->zebra_connected = bfd_nht_zclient_connected;
thread_add_timer(tm, bfd_nht_zclient_connect, bsglobal.nht_zclient, 1, thread_add_timer(tm, bfd_nht_zclient_connect, bsglobal.nht_zclient, 1,
&bsglobal.nht_zclient->t_connect); &bsglobal.nht_zclient->t_connect);
hook_register(frr_fini, bfd_protocol_integration_finish);
} }
void bfd_protocol_integration_set_debug(bool enable) void bfd_protocol_integration_set_debug(bool enable)