proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 04:26:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

developer: workflow.rst - add text on how to respond to reviews/comments

Browse Source 
add note that author's shouldn't remove a comment or review.
           also add a note that automatically generated comments can
           be deleted by authors and others when such comments are not
           the most results from that automated comment source.

Signed-off-by: Lou Berger <lberger@labn.net>
This commit is contained in:
Lou Berger 2018-03-27 08:08:15 -04:00
parent 6a32d26634
commit 493e3eed5d
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/developer/workflow.rst
View File

@ -256,7 +256,15 @@ After submitting your changes
- Wait for reviewers. Someone will review your code or be assigned
to review your code.
- Respond to any comments or concerns the reviewer has.
- Respond to any comments or concerns the reviewer has. Use e-mail or
add a comment via github to respond or to let the reviewer know how
their comment or concern is addressed.
- An author must never delete or manually dismiss someone else's comments
or review. (A review may be overridden by agreement in the weekly
technical meeting.)
- Automatically generated comments, e.g., those generated by CI systems,
may be deleted by authors and others when such comments are not the most
results from that automated comment source.
- After all comments and concerns are addressed, expect your patch
to be merged.