proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-09 03:47:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: use stop event instead of pthread_kill()

Browse Source 
When terminating I/O thread, just schedule an event to do any necessary
cleanup and gracefully exit instead of using a signal.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
This commit is contained in:
Quentin Young 2017-06-09 18:10:59 +00:00
parent 51abb4b49f
commit 48e5262f64
No known key found for this signature in database
GPG Key ID: DAF48E0F57E0834F
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
bgpd/bgp_io.c
View File

@ -84,14 +84,23 @@ void *bgp_io_start(void *arg)
return NULL; return NULL;
} }
static int bgp_io_finish(struct thread *thread)
{
/* if we ever have resources to clean up, that code should be placed in
* a pthread_cleanup handler and called from here */
/* set stop flag */
atomic_store_explicit(&bgp_io_thread_run, false, memory_order_relaxed);
return 0;
}
int bgp_io_stop(void **result, struct frr_pthread *fpt) int bgp_io_stop(void **result, struct frr_pthread *fpt)
{ {
/* schedule stop job */
thread_add_event(fpt->master, &bgp_io_finish, NULL, 0, NULL);
bgp_io_thread_run = false; /* join */
/* let the loop break */
fpt->master->spin = false;
/* break poll */
pthread_kill(fpt->thread, SIGINT);
pthread_join(fpt->thread, result); pthread_join(fpt->thread, result);
return 0; return 0;