proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2026-01-08 04:52:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert my "microfix". It was caused by misreading code. Gilad is right as

Browse Source 
always.
This commit is contained in:
hasso 2003-12-22 16:49:15 +00:00
parent 7639803406
commit 47ce02a8f1
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2003-12-22 Hasso Tepper <hasso@estpak.ee>
* lib/linklist.c: Revert microfix I commited while reverting
[quagga-dev 227]. Caused by misreading code.
2003-12-21 Hasso Tepper <hasso@estpak.ee>
* lib/linklist.c: Revert patch [quagga-dev 227]. listnode_add_sort()

7
lib/linklist.c
View File

@ -85,10 +85,6 @@ listnode_add (struct list *list, void *val)
* cmp function, insert a new node with the given val such that the
* list remains sorted. The new node is always inserted; there is no
* notion of omitting duplicates.
*
* XXX not sure this is right:
* It is currently undefined whether new nodes for which cmp returns 0
* should be added before or after any existing nodes.
*/
void
listnode_add_sort (struct list *list, void *val)
@ -103,8 +99,7 @@ listnode_add_sort (struct list *list, void *val)
{
for (n = list->head; n; n = n->next)
{
/* XXX should an "equal" node be inserted before or after? */
if ((*list->cmp) (val, n->data) <= 0)
if ((*list->cmp) (val, n->data) < 0)
{
new->next = n;
new->prev = n->prev;