proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-12 05:34:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

eigrpd: Tone down warning when command is not implemented yet

Browse Source 
Currently eigrp has a bunch of commands that are not fully
implemented yet.  Tone down the yang code change of making
these in your face errors to zlog_warns, so the end-user
can not be freaked out by the message.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2020-10-14 07:23:02 -04:00
parent 84de5a245a
commit 45afb6f701
1 changed files with 26 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
eigrpd/eigrp_northbound.c
View File

@ -243,10 +243,12 @@ static int eigrpd_instance_active_time_modify(struct nb_cb_modify_args *args)
switch (args->event) { switch (args->event) {
case NB_EV_VALIDATE: case NB_EV_VALIDATE:
/* TODO: Not implemented. */ /* TODO: Not implemented. */
return NB_ERR_INCONSISTENCY;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT:
return NB_OK;
case NB_EV_APPLY: case NB_EV_APPLY:
snprintf(args->errmsg, args->errmsg_len,
"active time not implemented yet");
/* NOTHING */ /* NOTHING */
break; break;
} }
@ -677,11 +679,12 @@ static int eigrpd_instance_neighbor_create(struct nb_cb_create_args *args)
switch (args->event) { switch (args->event) {
case NB_EV_VALIDATE: case NB_EV_VALIDATE:
/* TODO: Not implemented. */ /* TODO: Not implemented. */
return NB_ERR_INCONSISTENCY;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT:
return NB_OK;
case NB_EV_APPLY: case NB_EV_APPLY:
/* NOTHING */ snprintf(args->errmsg, args->errmsg_len,
"neighbor Command is not implemented yet");
break; break;
} }
@ -693,11 +696,12 @@ static int eigrpd_instance_neighbor_destroy(struct nb_cb_destroy_args *args)
switch (args->event) { switch (args->event) {
case NB_EV_VALIDATE: case NB_EV_VALIDATE:
/* TODO: Not implemented. */ /* TODO: Not implemented. */
return NB_ERR_INCONSISTENCY;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT:
return NB_OK;
case NB_EV_APPLY: case NB_EV_APPLY:
/* NOTHING */ snprintf(args->errmsg, args->errmsg_len,
"no neighbor Command is not implemented yet");
break; break;
} }
@ -768,11 +772,13 @@ eigrpd_instance_redistribute_route_map_modify(struct nb_cb_modify_args *args)
switch (args->event) { switch (args->event) {
case NB_EV_VALIDATE: case NB_EV_VALIDATE:
/* TODO: Not implemented. */ /* TODO: Not implemented. */
return NB_ERR_INCONSISTENCY;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT:
return NB_OK;
case NB_EV_APPLY: case NB_EV_APPLY:
/* NOTHING */ snprintf(
args->errmsg, args->errmsg_len,
"'redistribute X route-map FOO' command not implemented yet");
break; break;
} }
@ -785,11 +791,13 @@ eigrpd_instance_redistribute_route_map_destroy(struct nb_cb_destroy_args *args)
switch (args->event) { switch (args->event) {
case NB_EV_VALIDATE: case NB_EV_VALIDATE:
/* TODO: Not implemented. */ /* TODO: Not implemented. */
return NB_ERR_INCONSISTENCY;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT:
return NB_OK;
case NB_EV_APPLY: case NB_EV_APPLY:
/* NOTHING */ snprintf(
args->errmsg, args->errmsg_len,
"'no redistribute X route-map FOO' command not implemented yet");
break; break;
} }
@ -1079,10 +1087,12 @@ lib_interface_eigrp_split_horizon_modify(struct nb_cb_modify_args *args)
switch (args->event) { switch (args->event) {
case NB_EV_VALIDATE: case NB_EV_VALIDATE:
/* TODO: Not implemented. */ /* TODO: Not implemented. */
return NB_ERR_INCONSISTENCY;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT:
return NB_OK;
case NB_EV_APPLY: case NB_EV_APPLY:
snprintf(args->errmsg, args->errmsg_len,
"split-horizon command not implemented yet");
/* NOTHING */ /* NOTHING */
break; break;
} }
@ -1161,11 +1171,12 @@ static int lib_interface_eigrp_instance_summarize_addresses_create(
switch (args->event) { switch (args->event) {
case NB_EV_VALIDATE: case NB_EV_VALIDATE:
/* TODO: Not implemented. */ /* TODO: Not implemented. */
return NB_ERR_INCONSISTENCY;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT:
return NB_OK;
case NB_EV_APPLY: case NB_EV_APPLY:
/* NOTHING */ snprintf(args->errmsg, args->errmsg_len,
"summary command not implemented yet");
break; break;
} }
@ -1178,10 +1189,12 @@ static int lib_interface_eigrp_instance_summarize_addresses_destroy(
switch (args->event) { switch (args->event) {
case NB_EV_VALIDATE: case NB_EV_VALIDATE:
/* TODO: Not implemented. */ /* TODO: Not implemented. */
return NB_ERR_INCONSISTENCY;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT:
return NB_OK;
case NB_EV_APPLY: case NB_EV_APPLY:
snprintf(args->errmsg, args->errmsg_len,
"no summary command not implemented yet");
/* NOTHING */ /* NOTHING */
break; break;
} }