proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 04:47:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Convert bgp_packet_mpattr_prefix_size to use an enum

Browse Source 
The function bgp_packet_mpattr_prefix_size had an if/else
body that allowed people to add encoding types to bgpd
such that we could build the wrong size packets.  This
was exposed recently in commit:
0a9705a1e0

Where it was discovered flowspec was causing bgp update
messages to exceed the maximum size and the peer to
drop the connection.  Let's be proscriptive about this
and hopefully make it so that things don't work when
someone adds a new safi to the system ( and they'll have
to update this function ).

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2022-12-16 07:58:54 -05:00
parent 960ad09f93
commit 4487f0bd2c
1 changed files with 30 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
bgpd/bgp_attr.c
View File

@ -3979,15 +3979,39 @@ size_t bgp_packet_mpattr_prefix_size(afi_t afi, safi_t safi,
const struct prefix *p) const struct prefix *p)
{ {
int size = PSIZE(p->prefixlen); int size = PSIZE(p->prefixlen);
if (safi == SAFI_MPLS_VPN)
switch (safi) {
case SAFI_UNSPEC:
case SAFI_MAX:
assert(!"Attempting to figure size for a SAFI_UNSPEC/SAFI_MAX this is a DEV ESCAPE");
break;
case SAFI_UNICAST:
case SAFI_MULTICAST:
break;
case SAFI_MPLS_VPN:
size += 88; size += 88;
else if (safi == SAFI_LABELED_UNICAST) break;
case SAFI_ENCAP:
/* This has to be wrong, but I don't know what to put here */
assert(!"Do we try to use this?");
break;
case SAFI_LABELED_UNICAST:
size += BGP_LABEL_BYTES; size += BGP_LABEL_BYTES;
else if (afi == AFI_L2VPN && safi == SAFI_EVPN) break;
size += 232; // TODO: Maximum possible for type-2, type-3 and case SAFI_EVPN:
// type-5 /*
else if (safi == SAFI_FLOWSPEC) * TODO: Maximum possible for type-2, type-3 and type-5
*/
if (afi == AFI_L2VPN)
size += 232;
else
assert(!"Attempting to figure size for SAFI_EVPN and !AFI_L2VPN and FRR will not have the proper values");
break;
case SAFI_FLOWSPEC:
size = ((struct prefix_fs *)p)->prefix.prefixlen; size = ((struct prefix_fs *)p)->prefix.prefixlen;
break;
}
return size; return size;
} }