Merge pull request #10313 from anlancs/fix-ospf-check

ospfd,ospf6d: fix wrong comparison of routemap name
This commit is contained in:
Igor Ryzhov 2022-01-11 11:32:12 +03:00 committed by GitHub
commit 421ea99ebf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 12 deletions

View File

@ -1936,13 +1936,13 @@ DEFPY (ospf6_default_route_originate,
if (mtype_str == NULL)
mtype = -1;
/* To check ,if user is providing same route map */
if ((rtmap == ROUTEMAP_NAME(red))
|| (rtmap && ROUTEMAP_NAME(red)
&& (strcmp(rtmap, ROUTEMAP_NAME(red)) == 0)))
/* To check if user is providing same route map */
if ((!rtmap && !ROUTEMAP_NAME(red)) ||
(rtmap && ROUTEMAP_NAME(red) &&
(strcmp(rtmap, ROUTEMAP_NAME(red)) == 0)))
sameRtmap = true;
/* Don't allow if the same lsa is aleardy originated. */
/* Don't allow if the same lsa is already originated. */
if ((sameRtmap) && (red->dmetric.type == mtype)
&& (red->dmetric.value == mval)
&& (cur_originate == default_originate))

View File

@ -9275,7 +9275,7 @@ DEFUN (ospf_default_information_originate,
struct ospf_redist *red;
int idx = 0;
int cur_originate = ospf->default_originate;
int sameRtmap = 0;
bool sameRtmap = false;
char *rtmap = NULL;
red = ospf_redist_add(ospf, DEFAULT_ROUTE, 0);
@ -9300,13 +9300,13 @@ DEFUN (ospf_default_information_originate,
if (argv_find(argv, argc, "WORD", &idx))
rtmap = argv[idx]->arg;
/* To check ,if user is providing same route map */
if ((rtmap == ROUTEMAP_NAME(red)) ||
(rtmap && ROUTEMAP_NAME(red)
&& (strcmp(rtmap, ROUTEMAP_NAME(red)) == 0)))
sameRtmap = 1;
/* To check if user is providing same route map */
if ((!rtmap && !ROUTEMAP_NAME(red)) ||
(rtmap && ROUTEMAP_NAME(red) &&
(strcmp(rtmap, ROUTEMAP_NAME(red)) == 0)))
sameRtmap = true;
/* Don't allow if the same lsa is aleardy originated. */
/* Don't allow if the same lsa is already originated. */
if ((sameRtmap)
&& (red->dmetric.type == type)
&& (red->dmetric.value == metric)