proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-27 08:32:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #17114 from Jafaral/getenv

Browse Source 
vtysh: fix SA warning, no need to call getenv() twice
This commit is contained in:
Donatas Abraitis 2024-10-16 10:50:02 +03:00 committed by GitHub
commit 40dce0be6a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
vtysh/vtysh_main.c
View File

@ -350,6 +350,7 @@ int main(int argc, char **argv, char **env)
char pathspace[MAXPATHLEN] = ""; char pathspace[MAXPATHLEN] = "";
const char *histfile = NULL; const char *histfile = NULL;
const char *histfile_env = getenv("VTYSH_HISTFILE"); const char *histfile_env = getenv("VTYSH_HISTFILE");
const char *logpath = getenv("VTYSH_LOG");
/* SUID: drop down to calling user & go back up when needed */ /* SUID: drop down to calling user & go back up when needed */
elevuid = geteuid(); elevuid = geteuid();
@ -643,9 +644,7 @@ int main(int argc, char **argv, char **env)
} }
} }
if (getenv("VTYSH_LOG")) { if (logpath != NULL) {
const char *logpath = getenv("VTYSH_LOG");
logfile = fopen(logpath, "a"); logfile = fopen(logpath, "a");
if (!logfile) { if (!logfile) {
fprintf(stderr, "Failed to open logfile (%s): %s\n", fprintf(stderr, "Failed to open logfile (%s): %s\n",