tests: Check if the peer stays Idle if router-id is not set

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit 48560b5c9b)
This commit is contained in:
Donatas Abraitis 2025-01-29 23:11:35 +02:00 committed by Mergify
parent 46d210ce80
commit 3f788da60b
5 changed files with 43 additions and 1 deletions

View File

@ -4,3 +4,6 @@ router bgp 65001
neighbor fe80:1::2 remote-as external neighbor fe80:1::2 remote-as external
neighbor fe80:1::2 timers 3 10 neighbor fe80:1::2 timers 3 10
neighbor fe80:1::2 interface r1-eth0 neighbor fe80:1::2 interface r1-eth0
neighbor fe80:1::3 remote-as external
neighbor fe80:1::3 timers 3 10
neighbor fe80:1::3 interface r1-eth1

View File

@ -2,3 +2,6 @@
interface r1-eth0 interface r1-eth0
ipv6 address fe80:1::1/64 ipv6 address fe80:1::1/64
! !
interface r1-eth1
ipv6 address fe80:1::1/64
!

View File

@ -0,0 +1,5 @@
router bgp 65003
no bgp ebgp-requires-policy
neighbor fe80:1::1 remote-as external
neighbor fe80:1::1 timers 3 10
neighbor fe80:1::1 interface r3-eth0

View File

@ -0,0 +1,4 @@
!
interface r3-eth0
ipv6 address fe80:1::3/64
!

View File

@ -27,13 +27,17 @@ pytestmark = [pytest.mark.bgpd]
def build_topo(tgen): def build_topo(tgen):
for routern in range(1, 3): for routern in range(1, 4):
tgen.add_router("r{}".format(routern)) tgen.add_router("r{}".format(routern))
switch = tgen.add_switch("s1") switch = tgen.add_switch("s1")
switch.add_link(tgen.gears["r1"]) switch.add_link(tgen.gears["r1"])
switch.add_link(tgen.gears["r2"]) switch.add_link(tgen.gears["r2"])
switch = tgen.add_switch("s2")
switch.add_link(tgen.gears["r1"])
switch.add_link(tgen.gears["r3"])
def setup_module(mod): def setup_module(mod):
tgen = Topogen(build_topo, mod.__name__) tgen = Topogen(build_topo, mod.__name__)
@ -64,6 +68,7 @@ def test_bgp_ipv6_link_local_peering():
pytest.skip(tgen.errors) pytest.skip(tgen.errors)
r1 = tgen.gears["r1"] r1 = tgen.gears["r1"]
r3 = tgen.gears["r3"]
def _bgp_converge(): def _bgp_converge():
output = json.loads(r1.vtysh_cmd("show bgp summary json")) output = json.loads(r1.vtysh_cmd("show bgp summary json"))
@ -82,6 +87,28 @@ def test_bgp_ipv6_link_local_peering():
_, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5) _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
assert result is None, "Failed to see BGP convergence on R2" assert result is None, "Failed to see BGP convergence on R2"
def _bgp_router_id_missing():
output = json.loads(r3.vtysh_cmd("show bgp summary failed json"))
expected = {
"ipv4Unicast": {
"routerId": "0.0.0.0",
"as": 65003,
"peers": {
"fe80:1::1": {
"connectionsEstablished": 0,
"connectionsDropped": 0,
"peerUptime": "never",
"lastResetDueTo": "Router ID is missing",
}
},
}
}
return topotest.json_cmp(output, expected)
test_func = functools.partial(_bgp_router_id_missing)
_, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
assert result is None, "r3 should stay down due to missing router ID"
if __name__ == "__main__": if __name__ == "__main__":
args = ["-s"] + sys.argv[1:] args = ["-s"] + sys.argv[1:]