From 3b56a646b20fedb893863ff969dd8e47dc5d21c8 Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Wed, 11 Jan 2023 15:53:31 +0200 Subject: [PATCH] bgpd: Warn an operator, that the peer MUST be created before configuring rest For now, if the order was mixed, most of the commands are just silently ignored. Let the operator notice that. Signed-off-by: Donatas Abraitis --- bgpd/bgp_vty.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c index 8ea9c1996b..78816b0e04 100644 --- a/bgpd/bgp_vty.c +++ b/bgpd/bgp_vty.c @@ -819,6 +819,9 @@ struct peer *peer_and_group_lookup_vty(struct vty *vty, const char *peer_str) if (peer) { if (peer_dynamic_neighbor(peer)) { + zlog_warn( + "%pBP: Operation not allowed on a dynamic neighbor", + peer); vty_out(vty, "%% Operation not allowed on a dynamic neighbor\n"); return NULL; @@ -830,6 +833,8 @@ struct peer *peer_and_group_lookup_vty(struct vty *vty, const char *peer_str) if (group) return group->conf; + zlog_warn("Specify remote-as or peer-group commands first before: %s", + vty->buf); vty_out(vty, "%% Specify remote-as or peer-group commands first\n"); return NULL;