proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-27 11:44:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #4288 from qlyoung/checkpatch-unsafe-function-lints

Browse Source 
tools: add lints for unsafe functions
This commit is contained in:
Renato Westphal 2019-05-10 07:16:24 -03:00 committed by GitHub
commit 3ae6477f50
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
tools/checkpatch.pl
View File

@ -6347,6 +6347,35 @@ sub process {
"Please, only use 32 bit atomics.\n" . $herecurr);
}
# check for use of strcpy()
if ($line =~ /\bstrcpy\s*\(.*\)/) {
ERROR("STRCPY",
"strcpy() is error-prone; please use strlcpy()" . $herecurr);
}
# check for use of strncpy()
if ($line =~ /\bstrncpy\s*\(.*\)/) {
WARN("STRNCPY",
"strncpy() is error-prone; please use strlcpy() if possible, or memcpy()" . $herecurr);
}
# check for use of strcat()
if ($line =~ /\bstrcat\s*\(.*\)/) {
ERROR("STRCAT",
"strcat() is error-prone; please use strlcat() if possible" . $herecurr);
}
# check for use of strncat()
if ($line =~ /\bstrncat\s*\(.*\)/) {
WARN("STRNCAT",
"strncat() is error-prone; please use strlcat() if possible" . $herecurr);
}
# check for use of bzero()
if ($line =~ /\bbzero\s*\(.*\)/) {
ERROR("BZERO",
"bzero() is deprecated; use memset()" . $herecurr);
}
}
# If we have no input at all, then there is nothing to report on