proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-25 22:00:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: fix deference before check in rpki_create_socket

Browse Source 
Fix deference before check coverity scanner issue 1575918 in
rpki_create_socket()

Fixes: a951752d4a ("bgpd: create cache server socket in vrf")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
This commit is contained in:
Louis Scalbert 2024-01-23 09:29:26 +01:00
parent 8c8bb3568a
commit 39c8c97d41
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bgpd/bgp_rpki.c
View File

@ -1276,7 +1276,7 @@ static int rpki_create_socket(void *_cache)
{ {
struct timeval prev_snd_tmout, prev_rcv_tmout, timeout; struct timeval prev_snd_tmout, prev_rcv_tmout, timeout;
struct cache *cache = (struct cache *)_cache; struct cache *cache = (struct cache *)_cache;
struct rpki_vrf *rpki_vrf = cache->rpki_vrf; struct rpki_vrf *rpki_vrf;
struct tr_tcp_config *tcp_config; struct tr_tcp_config *tcp_config;
struct addrinfo *res = NULL; struct addrinfo *res = NULL;
struct addrinfo hints = {}; struct addrinfo hints = {};
@ -1294,6 +1294,8 @@ static int rpki_create_socket(void *_cache)
if (!cache) if (!cache)
return -1; return -1;
rpki_vrf = cache->rpki_vrf;
if (rpki_vrf->vrfname == NULL) if (rpki_vrf->vrfname == NULL)
vrf = vrf_lookup_by_id(VRF_DEFAULT); vrf = vrf_lookup_by_id(VRF_DEFAULT);
else else