proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-03 02:22:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tests: Fix random failure in test_PIM_hello_tx_rx_p1

Browse Source 
The test case test_PIM_hello_tx_rx_p1 is failing randomly because
sometimes the hello packet is received and sometimes not received while getting
the stats data.
When the hello packet is received HelloRx gets incremented to 1 and then
shutdown of the interface is executed which resets the stats to 0
and again when "no shutdown" of the interface is done, the stats get incremented to 1.
The test case checks after "no shutdown" of the interface whether the stats is incremented
but in this case although the stats got incremented the before and after value is same.
Hence the test case failed.

Adding correct expectations in the test case.

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
This commit is contained in:
Mobashshera Rasool 2022-01-16 00:25:23 -08:00
parent 2aa2e59320
commit 3996d25e3c
1 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py
View File

@ -197,6 +197,28 @@ def teardown_module():
#####################################################
def reset_stats(stats):
"""
API to reset the stats
Parameters
----------
* `stats` : State dictionary holding helloRx and helloTx values
"""
for router, state_data in stats.items():
for state, value in state_data.items():
stats[router][state] = 0
logger.info(
"[DUT: %s]: stats %s value has reset" " reset, Current value: %s",
router,
state,
stats[router][state],
)
return True
def verify_state_incremented(state_before, state_after):
"""
API to compare interface traffic state incrementing
@ -925,7 +947,6 @@ def test_PIM_hello_tx_rx_p1(request):
intf_l1_c1 = topo["routers"]["l1"]["links"]["c1"]["interface"]
intf_c1_l1 = topo["routers"]["c1"]["links"]["l1"]["interface"]
step("verify before stats on C1")
state_dict = {
"c1": {
intf_c1_l1: ["helloTx", "helloRx"],
@ -942,13 +963,12 @@ def test_PIM_hello_tx_rx_p1(request):
step("Flap PIM nbr while doing interface c1-l1 interface shut from f1 side")
shutdown_bringup_interface(tgen, "c1", intf_c1_l1, False)
step(
"After shut of local interface from c1 , verify rx/tx hello counters are cleared on c1 side"
"verify using 'show ip pim interface traffic'"
)
""" Resetting the stats here since shutdown resets the stats.
"""
reset_stats(c1_state_before)
shutdown_bringup_interface(tgen, "c1", intf_c1_l1, True)
step("verify stats after on c1 and that they are incremented")
step("verify stats after no shutdown on c1 and that they are incremented")
count = 0
done = False