proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-31 06:24:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pimd: Prevent crash of pim when auto-rp's socket is not initialized

Browse Source 
If the socket associated with the auto-rp fails to initialize then
the memory for the auto-rp is just dropped on the floor.  Additionally
any type of attempt at using the feature will just cause pimd to crash,
when the pointer is derefed.  Since it is derefed all over the place
without checking.

Clearly if you cannot bind/use the socket let's allow continuation.

Fixes: #17540
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2024-12-04 10:47:33 -05:00
parent 267dc19825
commit 37b88191fb
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pimd/pim_autorp.c
View File

@ -1508,12 +1508,14 @@ void pim_autorp_init(struct pim_instance *pim)
autorp->discovery_holdtime = DEFAULT_AUTORP_DISCOVERY_HOLDTIME;
cand_addrsel_clear(&(autorp->mapping_agent_addrsel));
pim->autorp = autorp;
if (!pim_autorp_socket_enable(autorp)) {
zlog_warn("%s: AutoRP failed to initialize", __func__);
zlog_warn("%s: AutoRP failed to initialize, feature will not work correctly",
__func__);
return;
}
pim->autorp = autorp;
if (PIM_DEBUG_AUTORP)
zlog_debug("%s: AutoRP Initialized", __func__);