proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-07 06:03:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Use strcmp comparing BGP alias with an actual entered alias

Browse Source 
It might be a case when a partial match is hit and this needs to be fixed.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
This commit is contained in:
Donatas Abraitis 2021-07-23 15:14:54 +03:00
parent c48ebbdb20
commit 35a45e8070
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bgpd/bgp_route.c
View File

@ -10862,8 +10862,7 @@ static int bgp_show_table(struct vty *vty, struct bgp *bgp, safi_t safi,
const char *com2alias = const char *com2alias =
bgp_community2alias( bgp_community2alias(
communities[i]); communities[i]);
if (strncmp(alias, com2alias, if (strcmp(alias, com2alias)
strlen(com2alias))
== 0) { == 0) {
found = true; found = true;
break; break;
@ -10878,8 +10877,7 @@ static int bgp_show_table(struct vty *vty, struct bgp *bgp, safi_t safi,
const char *com2alias = const char *com2alias =
bgp_community2alias( bgp_community2alias(
communities[i]); communities[i]);
if (strncmp(alias, com2alias, if (strcmp(alias, com2alias)
strlen(com2alias))
== 0) { == 0) {
found = true; found = true;
break; break;

4
bgpd/bgp_routemap.c
View File

@ -1195,7 +1195,7 @@ route_match_alias(void *rule, const struct prefix *prefix, void *object)
for (int i = 0; i < num; i++) { for (int i = 0; i < num; i++) {
const char *com2alias = const char *com2alias =
bgp_community2alias(communities[i]); bgp_community2alias(communities[i]);
if (strncmp(alias, com2alias, strlen(com2alias)) == 0) if (strcmp(alias, com2alias) == 0)
return RMAP_MATCH; return RMAP_MATCH;
} }
} }
@ -1206,7 +1206,7 @@ route_match_alias(void *rule, const struct prefix *prefix, void *object)
for (int i = 0; i < num; i++) { for (int i = 0; i < num; i++) {
const char *com2alias = const char *com2alias =
bgp_community2alias(communities[i]); bgp_community2alias(communities[i]);
if (strncmp(alias, com2alias, strlen(com2alias)) == 0) if (strcmp(alias, com2alias) == 0)
return RMAP_MATCH; return RMAP_MATCH;
} }
} }