proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 00:56:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pimd: Tell coverity what is really going on

Browse Source 
Fix a code path that coverity has decided a variable
is NULL when it never can be.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2023-04-21 07:38:11 -04:00
parent db865bf6ed
commit 35801e6234
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pimd/pim6_mld.c
View File

@ -2471,6 +2471,19 @@ static void gm_show_if_vrf(struct vty *vty, struct vrf *vrf, const char *ifname,
if (js) { if (js) {
js_if = json_object_new_object(); js_if = json_object_new_object();
/*
* If we have js as true and detail as false
* and if Coverity thinks that js_if is NULL
* because of a failed call to new then
* when we call gm_show_if_one below
* the tt can be deref'ed and as such
* FRR will crash. But since we know
* that json_object_new_object never fails
* then let's tell Coverity that this assumption
* is true. I'm not worried about fast path
* here at all.
*/
assert(js_if);
json_object_object_add(js_vrf, ifp->name, js_if); json_object_object_add(js_vrf, ifp->name, js_if);
} }