proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-04-30 06:42:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[warnings] Fix various SOS warnings

Browse Source 
2008-08-15 Paul Jakma <paul.jakma@sun.com>

	* */*: Fix various problems flagged by Sun Studio compiler.
	  - '<qualifier> <storage>' obsolescent in declarations
	  - empty statements (';' after ALIAS definitions)
	  - implicit declarations (e.g printstack in lib/log.c)
	  - "\%" in printf string instead of "%%"
	  - loops that return on the first iteration (legitimately, but
 	    compiler can't really know), e.g. bgp_routemap.c
 	  - internal declarations which mask prototypes.
This commit is contained in:
Paul Jakma 2008-08-15 14:05:22 +01:00 committed by Paul Jakma
parent f5612dd382
commit 30a2231a48
12 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bgpd/bgp_attr.c
View File

@ -2298,8 +2298,6 @@ bgp_packet_withdraw (struct peer *peer, struct stream *s, struct prefix *p,
void void
bgp_attr_init (void) bgp_attr_init (void)
{ {
void attrhash_init ();
aspath_init (); aspath_init ();
attrhash_init (); attrhash_init ();
community_init (); community_init ();

2
bgpd/bgp_route.c
View File

@ -9176,7 +9176,7 @@ bgp_table_stats (struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi)
vty_out (vty, "%12llu%s", ts.counts[i], VTY_NEWLINE); vty_out (vty, "%12llu%s", ts.counts[i], VTY_NEWLINE);
if (ts.counts[BGP_STATS_MAXBITLEN] < 9) if (ts.counts[BGP_STATS_MAXBITLEN] < 9)
break; break;
vty_out (vty, "%30s: ", "\% announced "); vty_out (vty, "%30s: ", "%% announced ");
vty_out (vty, "%12.2f%s", vty_out (vty, "%12.2f%s",
100 * (float)ts.counts[BGP_STATS_SPACE] / 100 * (float)ts.counts[BGP_STATS_SPACE] /
(float)((uint64_t)1UL << ts.counts[BGP_STATS_MAXBITLEN]), (float)((uint64_t)1UL << ts.counts[BGP_STATS_MAXBITLEN]),

7
bgpd/bgp_routemap.c
View File

@ -245,9 +245,8 @@ route_match_peer (void *rule, struct prefix *prefix, route_map_object_t type,
{ {
if (sockunion_same (su, &peer->su)) if (sockunion_same (su, &peer->su))
return RMAP_MATCH; return RMAP_MATCH;
return RMAP_NOMATCH;
} }
return RMAP_NOMATCH;
} }
} }
return RMAP_NOMATCH; return RMAP_NOMATCH;
@ -2574,7 +2573,7 @@ ALIAS (no_match_ip_route_source,
"Match advertising source address of route\n" "Match advertising source address of route\n"
"IP access-list number\n" "IP access-list number\n"
"IP access-list number (expanded range)\n" "IP access-list number (expanded range)\n"
"IP standard access-list name\n"); "IP standard access-list name\n")
DEFUN (match_ip_address_prefix_list, DEFUN (match_ip_address_prefix_list,
match_ip_address_prefix_list_cmd, match_ip_address_prefix_list_cmd,
@ -2685,7 +2684,7 @@ ALIAS (no_match_ip_route_source_prefix_list,
IP_STR IP_STR
"Match advertising source address of route\n" "Match advertising source address of route\n"
"Match entries of prefix-lists\n" "Match entries of prefix-lists\n"
"IP prefix-list name\n"); "IP prefix-list name\n")
DEFUN (match_metric, DEFUN (match_metric,
match_metric_cmd, match_metric_cmd,

1
lib/daemon.c
View File

@ -21,6 +21,7 @@
*/ */
#include <zebra.h> #include <zebra.h>
#include <log.h>
#ifndef HAVE_DAEMON #ifndef HAVE_DAEMON

2
lib/filter.c
View File

@ -138,7 +138,7 @@ filter_free (struct filter *filter)
} }
/* Return string of filter_type. */ /* Return string of filter_type. */
const static char * static const char *
filter_type_str (struct filter *filter) filter_type_str (struct filter *filter)
{ {
switch (filter->type) switch (filter->type)

4
lib/log.c
View File

@ -30,6 +30,10 @@
#ifndef SUNOS_5 #ifndef SUNOS_5
#include <sys/un.h> #include <sys/un.h>
#endif #endif
/* for printstack on solaris */
#ifdef HAVE_UCONTEXT_H
#include <ucontext.h>
#endif
static int logfile_fd = -1; /* Used in signal handler. */ static int logfile_fd = -1; /* Used in signal handler. */

2
lib/plist.c
View File

@ -518,7 +518,7 @@ prefix_list_entry_add (struct prefix_list *plist,
} }
/* Return string of prefix_list_type. */ /* Return string of prefix_list_type. */
const static char * static const char *
prefix_list_type_str (struct prefix_list_entry *pentry) prefix_list_type_str (struct prefix_list_entry *pentry)
{ {
switch (pentry->type) switch (pentry->type)

2
ospfclient/ospfclient.c
View File

@ -121,7 +121,7 @@ lsa_inject (struct thread *t)
counter++; counter++;
return 0; return 0;
}; }
/* This thread handles asynchronous messages coming in from the OSPF /* This thread handles asynchronous messages coming in from the OSPF

2
ospfd/ospf_ism.c
View File

@ -520,7 +520,7 @@ struct {
}, },
}; };
const static char *ospf_ism_event_str[] = static const char *ospf_ism_event_str[] =
{ {
"NoEvent", "NoEvent",
"InterfaceUp", "InterfaceUp",

2
ospfd/ospf_nsm.c
View File

@ -576,7 +576,7 @@ struct {
}, },
}; };
const static char *ospf_nsm_event_str[] = static const char *ospf_nsm_event_str[] =
{ {
"NoEvent", "NoEvent",
"HelloReceived", "HelloReceived",

2
ospfd/ospf_vty.c
View File

@ -50,7 +50,7 @@
#include "ospfd/ospf_dump.h" #include "ospfd/ospf_dump.h"
const static char *ospf_network_type_str[] = static const char *ospf_network_type_str[] =
{ {
"Null", "Null",
"POINTOPOINT", "POINTOPOINT",

1
zebra/rtadv.h
View File

@ -23,6 +23,7 @@
#ifndef _ZEBRA_RTADV_H #ifndef _ZEBRA_RTADV_H
#define _ZEBRA_RTADV_H #define _ZEBRA_RTADV_H
#include "vty.h"
#include "zebra/interface.h" #include "zebra/interface.h"
/* Router advertisement prefix. */ /* Router advertisement prefix. */