proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-28 14:21:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[lib] CID #39, fix leak in error path, vty_describe_command

Browse Source 
2006-05-12 Paul Jakma <paul.jakma@sun.com>

	* vty.c: (vty_describe_command) fix leak of describe vector in
	  error path, CID #39.
This commit is contained in:
Paul Jakma 2006-05-12 23:22:01 +00:00
parent d2519962b7
commit 2fe8aba3a0
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/ChangeLog
View File

@ -4,6 +4,8 @@
of prefix and typestr strings, Coverity CID #3.
* command.c: (cmd_complete_command_real) Fix leak of cmd_vector
in error case, Coverity CID #37.
* vty.c: (vty_describe_command) fix leak of describe vector in
error path, CID #39.
2006-03-30 Paul Jakma <paul.jakma@sun.com>

11
lib/vty.c
View File

@ -985,18 +985,12 @@ vty_describe_command (struct vty *vty)
switch (ret)
{
case CMD_ERR_AMBIGUOUS:
cmd_free_strvec (vline);
vty_out (vty, "%% Ambiguous command.%s", VTY_NEWLINE);
vty_prompt (vty);
vty_redraw_line (vty);
return;
goto out;
break;
case CMD_ERR_NO_MATCH:
cmd_free_strvec (vline);
vty_out (vty, "%% There is no matched command.%s", VTY_NEWLINE);
vty_prompt (vty);
vty_redraw_line (vty);
return;
goto out;
break;
}
@ -1066,6 +1060,7 @@ vty_describe_command (struct vty *vty)
vty_describe_fold (vty, width, desc_width, desc);
}
out:
cmd_free_strvec (vline);
vector_free (describe);