proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-13 22:26:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pimd assert when no route to source from a new igmp join

Browse Source 
When pim_upstream_new is called the code looks up the nexthop.
If there is no route to the source, the code silently ignored
the error returned.  When the nexthop lookup fails don't create
the 'struct pim_stream *' to return.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2015-06-12 17:47:26 -07:00 committed by Donald Sharp
parent a724477d97
commit 2f702571df
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pimd/pim_upstream.c
View File

@ -349,6 +349,7 @@ static struct pim_upstream *pim_upstream_new(struct in_addr source_addr,
struct in_addr group_addr) struct in_addr group_addr)
{ {
struct pim_upstream *up; struct pim_upstream *up;
enum pim_rpf_result rpf_result;
up = XMALLOC(MTYPE_PIM_UPSTREAM, sizeof(*up)); up = XMALLOC(MTYPE_PIM_UPSTREAM, sizeof(*up));
if (!up) { if (!up) {
@ -372,7 +373,11 @@ static struct pim_upstream *pim_upstream_new(struct in_addr source_addr,
up->rpf.source_nexthop.mrib_route_metric = qpim_infinite_assert_metric.route_metric; up->rpf.source_nexthop.mrib_route_metric = qpim_infinite_assert_metric.route_metric;
up->rpf.rpf_addr.s_addr = PIM_NET_INADDR_ANY; up->rpf.rpf_addr.s_addr = PIM_NET_INADDR_ANY;
pim_rpf_update(up, 0); rpf_result = pim_rpf_update(up, 0);
if (rpf_result == PIM_RPF_FAILURE) {
XFREE(MTYPE_PIM_UPSTREAM, up);
return NULL;
}
listnode_add(qpim_upstream_list, up); listnode_add(qpim_upstream_list, up);