proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-01 03:36:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ospf6d: don't create Adv-ID:0.0.0.0 LSAs at start

Browse Source 
When ospf6d comes up, it gets interface and address state before it
decides on its router ID.  This results in a bunch of LSAs with
advertising router ID 0.0.0.0 in the LSDB.  Not quite right.

There's a whole bunch of paths leading to this, so just drop the LSA in
ospf6_lsa_originate.  The router-ID change causes everything to be
readvertised anyway (... but the delete doesn't catch the 0.0.0.0 stuff
because the router-ID is now different.)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This commit is contained in:
David Lamparter 2021-06-28 16:29:56 +02:00
parent b08221513c
commit 2e9db233b1
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ospf6d/ospf6_flood.c
View File

@ -89,6 +89,16 @@ void ospf6_lsa_originate(struct ospf6_lsa *lsa)
struct ospf6_lsa *old; struct ospf6_lsa *old;
struct ospf6_lsdb *lsdb_self; struct ospf6_lsdb *lsdb_self;
if (lsa->header->adv_router == INADDR_ANY) {
if (IS_OSPF6_DEBUG_ORIGINATE_TYPE(lsa->header->type))
zlog_debug(
"Refusing to originate LSA (zero router ID): %s",
lsa->name);
ospf6_lsa_delete(lsa);
return;
}
/* find previous LSA */ /* find previous LSA */
old = ospf6_lsdb_lookup(lsa->header->type, lsa->header->id, old = ospf6_lsdb_lookup(lsa->header->type, lsa->header->id,
lsa->header->adv_router, lsa->lsdb); lsa->header->adv_router, lsa->lsdb);