From 271c00074fba9c04a4fe0b47a8c7e9a4cb0f2143 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Sun, 10 Sep 2023 09:35:38 -0400 Subject: [PATCH] bgpd: bgp_distance_unset ensure dest exists Coverity doesn't understand our locking scheme make sure it does a bit better. Signed-off-by: Donald Sharp --- bgpd/bgp_route.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c index 7d0cc377bd..4d4a2a5c35 100644 --- a/bgpd/bgp_route.c +++ b/bgpd/bgp_route.c @@ -15049,7 +15049,8 @@ static int bgp_distance_unset(struct vty *vty, const char *distance_str, bgp_distance_free(bdistance); bgp_dest_set_bgp_path_info(dest, NULL); - bgp_dest_unlock_node(dest); + dest = bgp_dest_unlock_node(dest); + assert(dest); bgp_dest_unlock_node(dest); return CMD_SUCCESS;