proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-04 00:38:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #16554 from donaldsharp/zebra_ensure_no_use_after_free

Browse Source 
zebra: Ensure non-equal id's are not same nhg's
This commit is contained in:
Donatas Abraitis 2024-08-12 07:59:42 +03:00 committed by GitHub
commit 263eb6d141
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
zebra/zebra_nhg.c
View File

@ -525,9 +525,18 @@ bool zebra_nhg_hash_equal(const void *arg1, const void *arg2)
struct nexthop *nexthop1;
struct nexthop *nexthop2;
/* No matter what if they equal IDs, assume equal */
if (nhe1->id && nhe2->id && (nhe1->id == nhe2->id))
return true;
/* If both NHG's have id's then we can just know that
* they are either identical or not. This comparison
* is only ever used for hash equality. NHE's id
* is sufficient to distinguish them. This is especially
* true if NHG's are owned by an upper level protocol.
*/
if (nhe1->id && nhe2->id) {
if (nhe1->id == nhe2->id)
return true;
return false;
}
if (nhe1->type != nhe2->type)
return false;