bgpd: Remove dead code for [un]register_zebra_rnh

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
Donatas Abraitis 2022-03-12 21:48:18 +02:00
parent 3b3b5ab350
commit 23f60ffd52

View File

@ -49,10 +49,8 @@
extern struct zclient *zclient; extern struct zclient *zclient;
static void register_zebra_rnh(struct bgp_nexthop_cache *bnc, static void register_zebra_rnh(struct bgp_nexthop_cache *bnc);
int is_bgp_static_route); static void unregister_zebra_rnh(struct bgp_nexthop_cache *bnc);
static void unregister_zebra_rnh(struct bgp_nexthop_cache *bnc,
int is_bgp_static_route);
static int make_prefix(int afi, struct bgp_path_info *pi, struct prefix *p); static int make_prefix(int afi, struct bgp_path_info *pi, struct prefix *p);
static void bgp_nht_ifp_initial(struct thread *thread); static void bgp_nht_ifp_initial(struct thread *thread);
@ -92,8 +90,7 @@ static void bgp_unlink_nexthop_check(struct bgp_nexthop_cache *bnc)
} }
/* only unregister if this is the last nh for this prefix*/ /* only unregister if this is the last nh for this prefix*/
if (!bnc_existing_for_prefix(bnc)) if (!bnc_existing_for_prefix(bnc))
unregister_zebra_rnh( unregister_zebra_rnh(bnc);
bnc, CHECK_FLAG(bnc->flags, BGP_STATIC_ROUTE));
bnc_free(bnc); bnc_free(bnc);
} }
} }
@ -308,7 +305,7 @@ int bgp_find_or_add_nexthop(struct bgp *bgp_route, struct bgp *bgp_nexthop,
SET_FLAG(bnc->flags, BGP_NEXTHOP_VALID); SET_FLAG(bnc->flags, BGP_NEXTHOP_VALID);
} else if (!CHECK_FLAG(bnc->flags, BGP_NEXTHOP_REGISTERED) } else if (!CHECK_FLAG(bnc->flags, BGP_NEXTHOP_REGISTERED)
&& !is_default_host_route(&bnc->prefix)) && !is_default_host_route(&bnc->prefix))
register_zebra_rnh(bnc, is_bgp_static_route); register_zebra_rnh(bnc);
if (pi && pi->nexthop != bnc) { if (pi && pi->nexthop != bnc) {
/* Unlink from existing nexthop cache, if any. This will also /* Unlink from existing nexthop cache, if any. This will also
@ -387,7 +384,7 @@ void bgp_delete_connected_nexthop(afi_t afi, struct peer *peer)
zlog_debug( zlog_debug(
"Freeing connected NHT node %p for peer %s(%s)", "Freeing connected NHT node %p for peer %s(%s)",
bnc, peer->host, bnc->bgp->name_pretty); bnc, peer->host, bnc->bgp->name_pretty);
unregister_zebra_rnh(bnc, 0); unregister_zebra_rnh(bnc);
bnc_free(bnc); bnc_free(bnc);
} }
} }
@ -915,8 +912,7 @@ static void sendmsg_zebra_rnh(struct bgp_nexthop_cache *bnc, int command)
* RETURNS: * RETURNS:
* void. * void.
*/ */
static void register_zebra_rnh(struct bgp_nexthop_cache *bnc, static void register_zebra_rnh(struct bgp_nexthop_cache *bnc)
int is_bgp_import_route)
{ {
/* Check if we have already registered */ /* Check if we have already registered */
if (bnc->flags & BGP_NEXTHOP_REGISTERED) if (bnc->flags & BGP_NEXTHOP_REGISTERED)
@ -937,8 +933,7 @@ static void register_zebra_rnh(struct bgp_nexthop_cache *bnc,
* RETURNS: * RETURNS:
* void. * void.
*/ */
static void unregister_zebra_rnh(struct bgp_nexthop_cache *bnc, static void unregister_zebra_rnh(struct bgp_nexthop_cache *bnc)
int is_bgp_import_route)
{ {
/* Check if we have already registered */ /* Check if we have already registered */
if (!CHECK_FLAG(bnc->flags, BGP_NEXTHOP_REGISTERED)) if (!CHECK_FLAG(bnc->flags, BGP_NEXTHOP_REGISTERED))
@ -1173,7 +1168,7 @@ void bgp_nht_register_nexthops(struct bgp *bgp)
frr_each (bgp_nexthop_cache, &bgp->nexthop_cache_table[afi], frr_each (bgp_nexthop_cache, &bgp->nexthop_cache_table[afi],
bnc) { bnc) {
register_zebra_rnh(bnc, 0); register_zebra_rnh(bnc);
} }
} }
} }