proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 06:50:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: fix conversion of yang decimal64 to double

Browse Source 
Current denominators are not integers and some of them lose precision
because of that, for example, 1e-6 is actually stored as
9.9999999999999995e-07 and 1-e12 is stored as 9.9999999999999998e-13.
When multiplying by such denominators, we receive incorrect values.
Changing denominators to integers and using division instead of
multiplication improves precision and solves the problem.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
This commit is contained in:
Igor Ryzhov 2024-01-20 03:43:18 +02:00
parent 0a5b944aef
commit 20fe60f40d
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/yang_wrappers.c
View File

@ -168,10 +168,9 @@ struct yang_data *yang_data_new_dec64(const char *xpath, double value)
double yang_dnode_get_dec64(const struct lyd_node *dnode, const char *xpath_fmt, double yang_dnode_get_dec64(const struct lyd_node *dnode, const char *xpath_fmt,
...) ...)
{ {
const double denom[19] = {1e0, 1e-1, 1e-2, 1e-3, 1e-4, const double denom[19] = { 1e0, 1e1, 1e2, 1e3, 1e4, 1e5, 1e6,
1e-5, 1e-6, 1e-7, 1e-8, 1e-9, 1e7, 1e8, 1e9, 1e10, 1e11, 1e12, 1e13,
1e-10, 1e-11, 1e-12, 1e-13, 1e-14, 1e14, 1e15, 1e16, 1e17, 1e18 };
1e-15, 1e-16, 1e-17, 1e-18};
const struct lysc_type_dec *dectype; const struct lysc_type_dec *dectype;
const struct lyd_value *dvalue; const struct lyd_value *dvalue;
@ -179,7 +178,7 @@ double yang_dnode_get_dec64(const struct lyd_node *dnode, const char *xpath_fmt,
dectype = (const struct lysc_type_dec *)dvalue->realtype; dectype = (const struct lysc_type_dec *)dvalue->realtype;
assert(dectype->basetype == LY_TYPE_DEC64); assert(dectype->basetype == LY_TYPE_DEC64);
assert(dectype->fraction_digits < sizeof(denom) / sizeof(*denom)); assert(dectype->fraction_digits < sizeof(denom) / sizeof(*denom));
return (double)dvalue->dec64 * denom[dectype->fraction_digits]; return (double)dvalue->dec64 / denom[dectype->fraction_digits];
} }
double yang_get_default_dec64(const char *xpath_fmt, ...) double yang_get_default_dec64(const char *xpath_fmt, ...)