proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 07:21:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

*: do not register nexthop 0.0.0.0 to nht

Browse Source 
Avoid tracking 0.0.0.0/32 nexthop with RIB.

When routes are aggregated,
the originate of the route becomes self.
Do not track nexthop self (0.0.0.0) with rib.

Ticket: CM-24248
Testing Done:

Before fix-

tor-11# show ip nht vrf all

VRF blue:
0.0.0.0
 unresolved
 Client list: bgp(fd 16)

VRF default:

VRF green:

VRF magenta:
0.0.0.0
 unresolved
 Client list: bgp(fd 16)

After fix-

tor-11# show ip nht vrf all

VRF blue:

VRF default:

VRF green:

VRF magenta:

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
This commit is contained in:
Chirag Shah 2019-04-02 18:47:46 -07:00
parent c5dafdbf5c
commit 1eb6c3eae6
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bgpd/bgp_nht.c
View File

@ -243,8 +243,10 @@ int bgp_find_or_add_nexthop(struct bgp *bgp_route, struct bgp *bgp_nexthop,
if (bgp_route->inst_type == BGP_INSTANCE_TYPE_VIEW) { if (bgp_route->inst_type == BGP_INSTANCE_TYPE_VIEW) {
SET_FLAG(bnc->flags, BGP_NEXTHOP_REGISTERED); SET_FLAG(bnc->flags, BGP_NEXTHOP_REGISTERED);
SET_FLAG(bnc->flags, BGP_NEXTHOP_VALID); SET_FLAG(bnc->flags, BGP_NEXTHOP_VALID);
} else if (!CHECK_FLAG(bnc->flags, BGP_NEXTHOP_REGISTERED)) } else if (!CHECK_FLAG(bnc->flags, BGP_NEXTHOP_REGISTERED) &&
!is_default_host_route(&bnc->node->p))
register_zebra_rnh(bnc, is_bgp_static_route); register_zebra_rnh(bnc, is_bgp_static_route);
if (pi && pi->nexthop != bnc) { if (pi && pi->nexthop != bnc) {
/* Unlink from existing nexthop cache, if any. This will also /* Unlink from existing nexthop cache, if any. This will also
* free * free

13
lib/prefix.h
View File

@ -511,6 +511,19 @@ static inline int is_host_route(struct prefix *p)
return 0; return 0;
} }
static inline int is_default_host_route(struct prefix *p)
{
if (p->family == AF_INET) {
return (p->u.prefix4.s_addr == INADDR_ANY &&
p->prefixlen == IPV4_MAX_BITLEN);
} else if (p->family == AF_INET6) {
return ((!memcmp(&p->u.prefix6, &in6addr_any,
sizeof(struct in6_addr))) &&
p->prefixlen == IPV6_MAX_BITLEN);
}
return 0;
}
#ifdef __cplusplus #ifdef __cplusplus
} }
#endif #endif