From 1dd3cd10b827c16d1a77ab4fb6cc56aff7b7a7be Mon Sep 17 00:00:00 2001 From: Stephen Worley Date: Fri, 9 Dec 2022 17:42:56 -0500 Subject: [PATCH] lib: add asserts to appease the SA I don't believe label can be NULL in any calling path but SA thinks so so let's just assert here to be safe anyway and make it happy. Signed-off-by: Stephen Worley --- lib/mpls.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/mpls.h b/lib/mpls.h index f89d3246ff..100d67e94b 100644 --- a/lib/mpls.h +++ b/lib/mpls.h @@ -139,6 +139,8 @@ static inline void vni2label(vni_t vni, mpls_label_t *label) { uint8_t *tag = (uint8_t *)label; + assert(tag); + tag[0] = (vni >> 16) & 0xFF; tag[1] = (vni >> 8) & 0xFF; tag[2] = vni & 0xFF; @@ -149,6 +151,8 @@ static inline vni_t label2vni(const mpls_label_t *label) uint8_t *tag = (uint8_t *)label; vni_t vni; + assert(tag); + vni = ((uint32_t)*tag++ << 16); vni |= (uint32_t)*tag++ << 8; vni |= (uint32_t)(*tag & 0xFF);