proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-29 19:11:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Cleanup debugs for bgp_zebra_route_notify_owner

Browse Source 
User %pRN as well as add some more debugs for other
interesting cases.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2021-01-05 15:22:57 -05:00
parent 92269aa253
commit 1a3519b69e
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
bgpd/bgp_zebra.c
View File

@ -2409,7 +2409,6 @@ static int bgp_zebra_route_notify_owner(int command, struct zclient *zclient,
struct prefix p; struct prefix p;
enum zapi_route_notify_owner note; enum zapi_route_notify_owner note;
uint32_t table_id; uint32_t table_id;
char buf[PREFIX_STRLEN];
afi_t afi; afi_t afi;
safi_t safi; safi_t safi;
struct bgp_dest *dest; struct bgp_dest *dest;
@ -2431,9 +2430,6 @@ static int bgp_zebra_route_notify_owner(int command, struct zclient *zclient,
return -1; return -1;
} }
if (BGP_DEBUG(zebra, ZEBRA))
prefix2str(&p, buf, sizeof(buf));
/* Find the bgp route node */ /* Find the bgp route node */
dest = bgp_afi_node_lookup(bgp->rib[afi][safi], afi, safi, &p, dest = bgp_afi_node_lookup(bgp->rib[afi][safi], afi, safi, &p,
&bgp->vrf_prd); &bgp->vrf_prd);
@ -2452,7 +2448,7 @@ static int bgp_zebra_route_notify_owner(int command, struct zclient *zclient,
BGP_NODE_FIB_INSTALL_PENDING); BGP_NODE_FIB_INSTALL_PENDING);
SET_FLAG(dest->flags, BGP_NODE_FIB_INSTALLED); SET_FLAG(dest->flags, BGP_NODE_FIB_INSTALLED);
if (BGP_DEBUG(zebra, ZEBRA)) if (BGP_DEBUG(zebra, ZEBRA))
zlog_debug("route %s : INSTALLED", buf); zlog_debug("route %pRN : INSTALLED", dest);
/* Find the best route */ /* Find the best route */
for (pi = dest->info; pi; pi = pi->next) { for (pi = dest->info; pi; pi = pi->next) {
/* Process aggregate route */ /* Process aggregate route */
@ -2468,8 +2464,8 @@ static int bgp_zebra_route_notify_owner(int command, struct zclient *zclient,
dest, new_select); dest, new_select);
else { else {
flog_err(EC_BGP_INVALID_ROUTE, flog_err(EC_BGP_INVALID_ROUTE,
"selected route %s not found", "selected route %pRN not found",
buf); dest);
return -1; return -1;
} }
} }
@ -2480,16 +2476,24 @@ static int bgp_zebra_route_notify_owner(int command, struct zclient *zclient,
* route add later * route add later
*/ */
UNSET_FLAG(dest->flags, BGP_NODE_FIB_INSTALLED); UNSET_FLAG(dest->flags, BGP_NODE_FIB_INSTALLED);
if (BGP_DEBUG(zebra, ZEBRA))
zlog_debug("route %pRN: Removed from Fib", dest);
break; break;
case ZAPI_ROUTE_FAIL_INSTALL: case ZAPI_ROUTE_FAIL_INSTALL:
if (BGP_DEBUG(zebra, ZEBRA))
zlog_debug("route: %pRN Failed to Install into Fib",
dest);
/* Error will be logged by zebra module */ /* Error will be logged by zebra module */
break; break;
case ZAPI_ROUTE_BETTER_ADMIN_WON: case ZAPI_ROUTE_BETTER_ADMIN_WON:
if (BGP_DEBUG(zebra, ZEBRA))
zlog_debug("route: %pRN removed due to better admin won",
dest);
/* No action required */ /* No action required */
break; break;
case ZAPI_ROUTE_REMOVE_FAIL: case ZAPI_ROUTE_REMOVE_FAIL:
zlog_warn("%s: Route %s failure to remove", zlog_warn("%s: Route %pRN failure to remove",
__func__, buf); __func__, dest);
break; break;
} }
return 0; return 0;