proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-26 23:23:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

isisd: fix update link params after circuit is up

Browse Source 
If the link-params are set when the circuit not yet up, the link-params
are never updated.

isis_link_params_update() is called from isis_circuit_up() but returns
immediately because circuit->state != C_STATE_UP. circuit->state is
updated in isis_csm_state_change after isis_circuit_up().

> struct isis_circuit *isis_csm_state_change(enum isis_circuit_event event,
> 					   struct isis_circuit *circuit,
> 					   void *arg)
> {
> [...]
> 			if (isis_circuit_up(circuit) != ISIS_OK) {
> 				isis_circuit_deconfigure(circuit, area);
> 				break;
> 			}
> 			circuit->state = C_STATE_UP;
> 			isis_event_circuit_state_change(circuit, circuit->area,
> 							1);

Do not return isis_link_params_update() if circuit->state != C_STATE_UP.

Fixes: 0fdd8b2b11 ("isisd: update link params after circuit is up")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit 6ce6b7a856)
This commit is contained in:
Louis Scalbert 2024-08-27 18:22:27 +02:00 committed by Mergify
parent 5af6b5875f
commit 15109e173f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
isisd/isis_te.c
View File

@ -331,7 +331,7 @@ void isis_link_params_update(struct isis_circuit *circuit,
return; return;
/* Sanity Check */ /* Sanity Check */
if ((ifp == NULL) || (circuit->state != C_STATE_UP)) if (ifp == NULL)
return; return;
te_debug("ISIS-TE(%s): Update circuit parameters for interface %s", te_debug("ISIS-TE(%s): Update circuit parameters for interface %s",