pimd: make pim interface hold interval range 1-630

Making the interface holdtime range to 3.5 times the hello-time

As per 7761, Section 4.11:
The Holdtime in a Hello message should be set to
   (3.5 * Hello_Period), giving a default value of 105 seconds.

Therefore providing the user also to configure max upto 3.5 times
the hello timer interval.

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
This commit is contained in:
github login name 2021-07-05 04:07:25 -07:00
parent 6eedc1a5b9
commit 142774530a
4 changed files with 6 additions and 6 deletions

View File

@ -199,7 +199,7 @@ is in a vrf, enter the interface command with the vrf keyword at the end.
Set the DR Priority for the interface. This command is useful to allow the Set the DR Priority for the interface. This command is useful to allow the
user to influence what node becomes the DR for a lan segment. user to influence what node becomes the DR for a lan segment.
.. clicmd:: ip pim hello (1-180) (1-180) .. clicmd:: ip pim hello (1-180) (1-630)
Set the pim hello and hold interval for a interface. Set the pim hello and hold interval for a interface.

View File

@ -8767,7 +8767,7 @@ DEFUN (interface_no_ip_mroute,
DEFUN (interface_ip_pim_hello, DEFUN (interface_ip_pim_hello,
interface_ip_pim_hello_cmd, interface_ip_pim_hello_cmd,
"ip pim hello (1-180) [(1-180)]", "ip pim hello (1-180) [(1-630)]",
IP_STR IP_STR
PIM_STR PIM_STR
IFACE_PIM_HELLO_STR IFACE_PIM_HELLO_STR
@ -8802,7 +8802,7 @@ DEFUN (interface_ip_pim_hello,
DEFUN (interface_no_ip_pim_hello, DEFUN (interface_no_ip_pim_hello,
interface_no_ip_pim_hello_cmd, interface_no_ip_pim_hello_cmd,
"no ip pim hello [(1-180) [(1-180)]]", "no ip pim hello [(1-180) [(1-630)]]",
NO_STR NO_STR
IP_STR IP_STR
PIM_STR PIM_STR

View File

@ -1613,7 +1613,7 @@ int lib_interface_pim_hello_holdtime_modify(struct nb_cb_modify_args *args)
ifp = nb_running_get_entry(args->dnode, NULL, true); ifp = nb_running_get_entry(args->dnode, NULL, true);
pim_ifp = ifp->info; pim_ifp = ifp->info;
pim_ifp->pim_default_holdtime = pim_ifp->pim_default_holdtime =
yang_dnode_get_uint8(args->dnode, NULL); yang_dnode_get_uint16(args->dnode, NULL);
break; break;
} }

View File

@ -351,8 +351,8 @@ module frr-pim {
} }
leaf hello-holdtime { leaf hello-holdtime {
type uint8 { type uint16 {
range "1..180"; range "1..630";
} }
must ". > ./../hello-interval" { must ". > ./../hello-interval" {
error-message "HoldTime must be greater than Hello"; error-message "HoldTime must be greater than Hello";