proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-07 17:18:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

zebra: improve identification of loopback interfaces in the router-id code

Browse Source 
The if_is_loopback() function is the right abstraction for identifying
loopback interfaces. There should be no reason for not using it in the
router-id code.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
This commit is contained in:
Renato Westphal 2018-11-17 21:33:37 -02:00
parent fef6daf4da
commit 106935f671
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
zebra/router-id.c
View File

@ -132,8 +132,7 @@ void router_id_add_address(struct connected *ifc)
router_id_get(&before, zvrf_id(zvrf)); router_id_get(&before, zvrf_id(zvrf));
if (!strncmp(ifc->ifp->name, "lo", 2) if (if_is_loopback(ifc->ifp))
|| !strncmp(ifc->ifp->name, "dummy", 5))
l = zvrf->rid_lo_sorted_list; l = zvrf->rid_lo_sorted_list;
else else
l = zvrf->rid_all_sorted_list; l = zvrf->rid_all_sorted_list;
@ -165,8 +164,7 @@ void router_id_del_address(struct connected *ifc)
router_id_get(&before, zvrf_id(zvrf)); router_id_get(&before, zvrf_id(zvrf));
if (!strncmp(ifc->ifp->name, "lo", 2) if (if_is_loopback(ifc->ifp))
|| !strncmp(ifc->ifp->name, "dummy", 5))
l = zvrf->rid_lo_sorted_list; l = zvrf->rid_lo_sorted_list;
else else
l = zvrf->rid_all_sorted_list; l = zvrf->rid_all_sorted_list;