proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-29 14:40:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #10358 from idryzhov/workflow-pr-cleanup

Browse Source 
doc: cleanup submitting patches and enhancements
This commit is contained in:
Donatas Abraitis 2022-01-18 10:48:30 +02:00 committed by GitHub
commit 0fd57f5600
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
doc/developer/workflow.rst
View File

@ -249,23 +249,13 @@ changelog with some better description.
Submitting Patches and Enhancements Submitting Patches and Enhancements
=================================== ===================================
FRR accepts patches from two sources: FRR accepts patches using GitHub pull requests.
- GitHub pull request
Contributors are highly encouraged to use GitHub's fork-and-PR workflow. It is
easier for us to review it, test it, try it and discuss it on GitHub than it is
via email, thus your patch will get more attention more quickly on GitHub.
The base branch for new contributions and non-critical bug fixes should be The base branch for new contributions and non-critical bug fixes should be
``master``. Please ensure your pull request is based on this branch when you ``master``. Please ensure your pull request is based on this branch when you
submit it. submit it.
GitHub Pull Requests Code submitted by pull request will be automatically tested by one or more CI
--------------------
The preferred method of submitting changes is a GitHub pull request. Code
submitted by pull request will be automatically tested by one or more CI
systems. Once the automated tests succeed, other developers will review your systems. Once the automated tests succeed, other developers will review your
code for quality and correctness. After any concerns are resolved, your code code for quality and correctness. After any concerns are resolved, your code
will be merged into the branch it was submitted against. will be merged into the branch it was submitted against.