From 0df2e1888b1e8011bc1e3ec6ed6c34a9e6fcaae9 Mon Sep 17 00:00:00 2001 From: Igor Ryzhov Date: Thu, 14 Oct 2021 21:06:38 +0300 Subject: [PATCH] lib: make if_lookup_by_name_all_vrf internal This function doesn't work correctly with netns VRF backend as the same ifname may be used in multiple netns simultaneously. So let's hide it from the public API to reduce temptation to use it instead of writing the correct code. Signed-off-by: Igor Ryzhov --- lib/if.c | 2 +- lib/if.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/if.c b/lib/if.c index 4d7862022c..446b40fb46 100644 --- a/lib/if.c +++ b/lib/if.c @@ -431,7 +431,7 @@ struct interface *if_lookup_by_name_vrf(const char *name, struct vrf *vrf) return RB_FIND(if_name_head, &vrf->ifaces_by_name, &if_tmp); } -struct interface *if_lookup_by_name_all_vrf(const char *name) +static struct interface *if_lookup_by_name_all_vrf(const char *name) { struct vrf *vrf; struct interface *ifp; diff --git a/lib/if.h b/lib/if.h index 59e75d8b68..60d571b54e 100644 --- a/lib/if.h +++ b/lib/if.h @@ -529,7 +529,6 @@ size_t if_lookup_by_hwaddr(const uint8_t *hw_addr, size_t addrsz, struct interface ***result, vrf_id_t vrf_id); struct vrf; -extern struct interface *if_lookup_by_name_all_vrf(const char *ifname); extern struct interface *if_lookup_by_name_vrf(const char *name, struct vrf *vrf); extern struct interface *if_lookup_by_name(const char *ifname, vrf_id_t vrf_id); extern struct interface *if_get_by_name(const char *ifname, vrf_id_t vrf_id);