proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-06 04:36:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[daemons] Sanity check port number arguments before use

Browse Source 
2008-05-29 Martin Nagy <mnagy@redhat.com>

	* */*main.c: Sanity check port numbers before using.
This commit is contained in:
Paul Jakma 2008-05-29 18:29:16 +00:00
parent 768a27ea7b
commit 0d6b2ee249
7 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -1,3 +1,7 @@
2008-05-29 Martin Nagy <mnagy@redhat.com>
* */*main.c: Sanity check port numbers before using.
2008-01-30 Peter Szilagyi <sp615@hszk.bme.hu> 2008-01-30 Peter Szilagyi <sp615@hszk.bme.hu>
* lib/stream.h: Remove named 'new' parameter in prototype * lib/stream.h: Remove named 'new' parameter in prototype

10
bgpd/bgp_main.c
View File

@ -203,6 +203,7 @@ main (int argc, char **argv)
int dryrun = 0; int dryrun = 0;
char *progname; char *progname;
struct thread thread; struct thread thread;
int tmp_port;
/* Set umask before anything for security */ /* Set umask before anything for security */
umask (0027); umask (0027);
@ -238,7 +239,11 @@ main (int argc, char **argv)
pid_file = optarg; pid_file = optarg;
break; break;
case 'p': case 'p':
bm->port = atoi (optarg); tmp_port = atoi (optarg);
if (tmp_port <= 0 || tmp_port > 0xffff)
bm->port = BGP_PORT_DEFAULT;
else
bm->port = tmp_port;
break; break;
case 'A': case 'A':
vty_addr = optarg; vty_addr = optarg;
@ -252,7 +257,8 @@ main (int argc, char **argv)
break; break;
} }
vty_port = atoi (optarg); vty_port = atoi (optarg);
vty_port = (vty_port ? vty_port : BGP_VTY_PORT); if (vty_port <= 0 || vty_port > 0xffff)
vty_port = BGP_VTY_PORT;
break; break;
case 'r': case 'r':
retain_mode = 1; retain_mode = 1;

3
ospf6d/ospf6_main.c
View File

@ -227,7 +227,8 @@ main (int argc, char *argv[], char *envp[])
break; break;
} }
vty_port = atoi (optarg); vty_port = atoi (optarg);
vty_port = (vty_port ? vty_port : OSPF6_VTY_PORT); if (vty_port <= 0 || vty_port > 0xffff)
vty_port = OSPF6_VTY_PORT;
break; break;
case 'u': case 'u':
ospf6d_privs.user = optarg; ospf6d_privs.user = optarg;

3
ospfd/ospf_main.c
View File

@ -245,7 +245,8 @@ main (int argc, char **argv)
break; break;
} }
vty_port = atoi (optarg); vty_port = atoi (optarg);
vty_port = (vty_port ? vty_port : OSPF_VTY_PORT); if (vty_port <= 0 || vty_port > 0xffff)
vty_port = OSPF_VTY_PORT;
break; break;
case 'u': case 'u':
ospfd_privs.user = optarg; ospfd_privs.user = optarg;

3
ripd/rip_main.c
View File

@ -236,7 +236,8 @@ main (int argc, char **argv)
break; break;
} }
vty_port = atoi (optarg); vty_port = atoi (optarg);
vty_port = (vty_port ? vty_port : RIP_VTY_PORT); if (vty_port <= 0 || vty_port > 0xffff)
vty_port = RIP_VTY_PORT;
break; break;
case 'r': case 'r':
retain_mode = 1; retain_mode = 1;

3
ripngd/ripng_main.c
View File

@ -240,7 +240,8 @@ main (int argc, char **argv)
break; break;
} }
vty_port = atoi (optarg); vty_port = atoi (optarg);
vty_port = (vty_port ? vty_port : RIPNG_VTY_PORT); if (vty_port <= 0 || vty_port > 0xffff)
vty_port = RIPNG_VTY_PORT;
break; break;
case 'r': case 'r':
retain_mode = 1; retain_mode = 1;

3
zebra/main.c
View File

@ -275,7 +275,8 @@ main (int argc, char **argv)
break; break;
} }
vty_port = atoi (optarg); vty_port = atoi (optarg);
vty_port = (vty_port ? vty_port : ZEBRA_VTY_PORT); if (vty_port <= 0 || vty_port > 0xffff)
vty_port = ZEBRA_VTY_PORT;
break; break;
case 'r': case 'r':
retain_mode = 1; retain_mode = 1;