From fd283bd250d9a6246f4405a7ad05438a96b8d951 Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Tue, 20 Sep 2022 10:45:02 +0300 Subject: [PATCH] bgpd: Use route_map_result_t for route_map_apply() as return type Signed-off-by: Donatas Abraitis --- bgpd/bgp_attr.c | 2 +- tools/coccinelle/route_map_apply.cocci | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 tools/coccinelle/route_map_apply.cocci diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c index d91c717f37..b7d0958bac 100644 --- a/bgpd/bgp_attr.c +++ b/bgpd/bgp_attr.c @@ -983,7 +983,7 @@ struct attr *bgp_attr_aggregate_intern( { struct attr attr; struct attr *new; - int ret; + route_map_result_t ret; memset(&attr, 0, sizeof(attr)); diff --git a/tools/coccinelle/route_map_apply.cocci b/tools/coccinelle/route_map_apply.cocci new file mode 100644 index 0000000000..ccca619d7e --- /dev/null +++ b/tools/coccinelle/route_map_apply.cocci @@ -0,0 +1,15 @@ +@rmap@ +identifier ret; +position p; +@@ + +int ret@p; +... +* ret = route_map_apply(...); + +@script:python@ +p << rmap.p; +@@ + +msg = "ERROR: Invalid type of return value variable for route_map_apply_ext()" +coccilib.report.print_report(p[0], msg)