proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-29 15:07:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Clear addpath RX flag if it's absent

Browse Source 
When we have RX/TX flags, but received only TX, we should clear RX flag, to avoid
receiving additional paths.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
Donatas Abraitis 2023-09-26 16:35:15 +03:00
parent 373d46d0f7
commit 058f3ff7ad
1 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
bgpd/bgp_open.c
View File

@ -709,15 +709,17 @@ static int bgp_capability_addpath(struct peer *peer,
uint8_t send_receive = stream_getc(s); uint8_t send_receive = stream_getc(s);
if (bgp_debug_neighbor_events(peer)) if (bgp_debug_neighbor_events(peer))
zlog_debug( zlog_debug("%s OPEN has %s capability for afi/safi: %s/%s%s%s",
"%s OPEN has %s capability for afi/safi: %s/%s%s%s", peer->host,
peer->host, lookup_msg(capcode_str, hdr->code, NULL),
lookup_msg(capcode_str, hdr->code, NULL), iana_afi2str(pkt_afi),
iana_afi2str(pkt_afi), iana_safi2str(pkt_safi), iana_safi2str(pkt_safi),
(send_receive & BGP_ADDPATH_RX) ? ", receive" CHECK_FLAG(send_receive, BGP_ADDPATH_RX)
: "", ? ", receive"
(send_receive & BGP_ADDPATH_TX) ? ", transmit" : "",
: ""); CHECK_FLAG(send_receive, BGP_ADDPATH_TX)
? ", transmit"
: "");
/* Convert AFI, SAFI to internal values, check. */ /* Convert AFI, SAFI to internal values, check. */
if (bgp_map_afi_safi_iana2int(pkt_afi, pkt_safi, &afi, &safi)) { if (bgp_map_afi_safi_iana2int(pkt_afi, pkt_safi, &afi, &safi)) {
@ -736,13 +738,19 @@ static int bgp_capability_addpath(struct peer *peer,
continue; continue;
} }
if (send_receive & BGP_ADDPATH_RX) if (CHECK_FLAG(send_receive, BGP_ADDPATH_RX))
SET_FLAG(peer->af_cap[afi][safi], SET_FLAG(peer->af_cap[afi][safi],
PEER_CAP_ADDPATH_AF_RX_RCV); PEER_CAP_ADDPATH_AF_RX_RCV);
else
UNSET_FLAG(peer->af_cap[afi][safi],
PEER_CAP_ADDPATH_AF_RX_RCV);
if (send_receive & BGP_ADDPATH_TX) if (CHECK_FLAG(send_receive, BGP_ADDPATH_TX))
SET_FLAG(peer->af_cap[afi][safi], SET_FLAG(peer->af_cap[afi][safi],
PEER_CAP_ADDPATH_AF_TX_RCV); PEER_CAP_ADDPATH_AF_TX_RCV);
else
UNSET_FLAG(peer->af_cap[afi][safi],
PEER_CAP_ADDPATH_AF_TX_RCV);
} }
return 0; return 0;