tests: Check if GR settings are inherited for peer-groups

Convert to unified config also.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit a4bfa8c574)

tests/topotests/bgp_peer_group/r1/bgpd.conf

@@ -1,12 +0,0 @@
-!
-router bgp 65001
-  neighbor PG peer-group
-  neighbor PG remote-as external
-  neighbor PG timers 3 10
-  neighbor 192.168.255.3 peer-group PG
-  neighbor r1-eth0 interface peer-group PG
-  neighbor PG1 peer-group
-  neighbor PG1 remote-as external
-  neighbor PG1 timers 3 20
-  neighbor 192.168.251.2 peer-group PG1
-!

tests/topotests/bgp_peer_group/r1/frr.conf

@@ -0,0 +1,21 @@
+!
+interface r1-eth0
+ ip address 192.168.255.1/24
+!
+interface r1-eth1
+ ip address 192.168.251.1/30
+!
+ip forwarding
+!
+router bgp 65001
+ neighbor PG peer-group
+ neighbor PG remote-as external
+ neighbor PG timers 3 10
+ neighbor 192.168.255.3 peer-group PG
+ neighbor r1-eth0 interface peer-group PG
+ neighbor PG1 peer-group
+ neighbor PG1 remote-as external
+ neighbor PG1 timers 3 20
+ neighbor PG1 graceful-restart-disable
+ neighbor 192.168.251.2 peer-group PG1
+!

tests/topotests/bgp_peer_group/r1/zebra.conf

@@ -1,9 +0,0 @@
-!
-interface r1-eth0
- ip address 192.168.255.1/24
-!
-interface r1-eth1
- ip address 192.168.251.1/30
-!
-ip forwarding
-!

tests/topotests/bgp_peer_group/r2/bgpd.conf

@@ -1,11 +0,0 @@
-!
-router bgp 65002
-  neighbor PG peer-group
-  neighbor PG remote-as external
-  neighbor PG timers 3 10
-  neighbor r2-eth0 interface peer-group PG
-  neighbor PG1 peer-group
-  neighbor PG1 remote-as external
-  neighbor PG1 timers 3 20
-  neighbor 192.168.251.1 peer-group PG1
-!

tests/topotests/bgp_peer_group/r2/frr.conf

@@ -0,0 +1,19 @@
+!
+interface r2-eth0
+ ip address 192.168.255.2/24
+!
+interface r2-eth1
+ ip address 192.168.251.2/30
+!
+ip forwarding
+!
+router bgp 65002
+ neighbor PG peer-group
+ neighbor PG remote-as external
+ neighbor PG timers 3 10
+ neighbor r2-eth0 interface peer-group PG
+ neighbor PG1 peer-group
+ neighbor PG1 remote-as external
+ neighbor PG1 timers 3 20
+ neighbor 192.168.251.1 peer-group PG1
+!

tests/topotests/bgp_peer_group/r2/zebra.conf

@@ -1,9 +0,0 @@
-!
-interface r2-eth0
- ip address 192.168.255.2/24
-!
-interface r2-eth1
- ip address 192.168.251.2/30
-!
-ip forwarding
-!

tests/topotests/bgp_peer_group/r3/frr.conf

@@ -1,4 +1,9 @@
 !
+interface r3-eth0
+ ip address 192.168.255.3/24
+!
+ip forwarding
+!
 router bgp 65003
  no bgp ebgp-requires-policy
  neighbor PG peer-group

tests/topotests/bgp_peer_group/r3/zebra.conf

@@ -1,6 +0,0 @@
-!
-interface r3-eth0
- ip address 192.168.255.3/24
-!
-ip forwarding
-!

tests/topotests/bgp_peer_group/test_bgp_peer-group.py

@@ -2,12 +2,14 @@
 # SPDX-License-Identifier: ISC
 
 #
-# Copyright (c) 2021 by
+# Copyright (c) 2021-2024 by
 # Donatas Abraitis <donatas.abraitis@gmail.com>
+# Donatas Abraitis <donatas@opensourcerouting.org>
 #
 
 """
-Test if peer-group works for numbered and unnumbered configurations.
+Test if various random settings with peer-group works for
+numbered and unnumbered configurations.
 """
 
 import os
@@ -21,7 +23,7 @@ sys.path.append(os.path.join(CWD, "../"))
 
 # pylint: disable=C0413
 from lib import topotest
-from lib.topogen import Topogen, TopoRouter, get_topogen
+from lib.topogen import Topogen, get_topogen
 from lib.topolog import logger
 
 pytestmark = [pytest.mark.bgpd]
@@ -48,12 +50,7 @@ def setup_module(mod):
     router_list = tgen.routers()
 
     for _, (rname, router) in enumerate(router_list.items(), 1):
-        router.load_config(
+        router.load_frr_config(os.path.join(CWD, "{}/frr.conf".format(rname)))
-            TopoRouter.RD_ZEBRA, os.path.join(CWD, "{}/zebra.conf".format(rname))
-        )
-        router.load_config(
-            TopoRouter.RD_BGP, os.path.join(CWD, "{}/bgpd.conf".format(rname))
-        )
 
     tgen.start_router()
 
@@ -72,14 +69,26 @@ def test_bgp_peer_group():
     def _bgp_peer_group_configured():
         output = json.loads(tgen.gears["r1"].vtysh_cmd("show ip bgp neighbor json"))
         expected = {
-            "r1-eth0": {"peerGroup": "PG", "bgpState": "Established"},
+            "r1-eth0": {
-            "192.168.255.3": {"peerGroup": "PG", "bgpState": "Established"},
+                "peerGroup": "PG",
-            "192.168.251.2": {"peerGroup": "PG1", "bgpState": "Established"},
+                "bgpState": "Established",
+                "neighborCapabilities": {"gracefulRestart": "advertisedAndReceived"},
+            },
+            "192.168.255.3": {
+                "peerGroup": "PG",
+                "bgpState": "Established",
+                "neighborCapabilities": {"gracefulRestart": "advertisedAndReceived"},
+            },
+            "192.168.251.2": {
+                "peerGroup": "PG1",
+                "bgpState": "Established",
+                "neighborCapabilities": {"gracefulRestart": "received"},
+            },
         }
         return topotest.json_cmp(output, expected)
 
     test_func = functools.partial(_bgp_peer_group_configured)
-    _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
+    _, result = topotest.run_and_expect(test_func, None, count=30, wait=1)
     assert result is None, "Failed bgp convergence in r1"
 
     def _bgp_peer_group_check_advertised_routes():
@@ -97,7 +106,7 @@ def test_bgp_peer_group():
         return topotest.json_cmp(output, expected)
 
     test_func = functools.partial(_bgp_peer_group_check_advertised_routes)
-    _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
+    _, result = topotest.run_and_expect(test_func, None, count=30, wait=1)
     assert result is None, "Failed checking advertised routes from r3"
 
 
@@ -122,7 +131,7 @@ def test_bgp_peer_group_remote_as_del_readd():
         return topotest.json_cmp(output, expected)
 
     test_func = functools.partial(_bgp_peer_group_remoteas_del)
-    _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
+    _, result = topotest.run_and_expect(test_func, None, count=30, wait=1)
     assert result is None, "Failed bgp convergence in r1"
 
     logger.info("Re-add bgp peer-group PG1 remote-as neighbor should be established")
@@ -139,7 +148,7 @@ def test_bgp_peer_group_remote_as_del_readd():
         return topotest.json_cmp(output, expected)
 
     test_func = functools.partial(_bgp_peer_group_remoteas_add)
-    _, result = topotest.run_and_expect(test_func, None, count=60, wait=0.5)
+    _, result = topotest.run_and_expect(test_func, None, count=30, wait=1)
     assert result is None, "Failed bgp convergence in r1"