From 006ef829d84f3d9d0a2bee486af1aca987dec36c Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Thu, 19 May 2022 19:28:43 -0400 Subject: [PATCH] tests: Allow a bit longer for bfd topo tests to synchronize Allowing only 4 seconds for a bfd test to synchronize is going to run into problems on extremely loaded systems. The test system should value it actually converged over it actually converged in a reasonable time, especially on test systems that are loaded because of many multiples of tests running at the same time. If it is important to actually test that something got done by the RFC, the CI system as it is currently written is not the correct place for this. Signed-off-by: Donald Sharp --- tests/topotests/bfd_topo1/test_bfd_topo1.py | 2 +- tests/topotests/bfd_topo2/test_bfd_topo2.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/topotests/bfd_topo1/test_bfd_topo1.py b/tests/topotests/bfd_topo1/test_bfd_topo1.py index adf02b02d4..c9020f16d3 100644 --- a/tests/topotests/bfd_topo1/test_bfd_topo1.py +++ b/tests/topotests/bfd_topo1/test_bfd_topo1.py @@ -100,7 +100,7 @@ def test_bfd_connection(): test_func = partial( topotest.router_json_cmp, router, "show bfd peers json", expected ) - _, result = topotest.run_and_expect(test_func, None, count=8, wait=0.5) + _, result = topotest.run_and_expect(test_func, None, count=30, wait=0.5) assertmsg = '"{}" JSON output mismatches'.format(router.name) assert result is None, assertmsg diff --git a/tests/topotests/bfd_topo2/test_bfd_topo2.py b/tests/topotests/bfd_topo2/test_bfd_topo2.py index 57ce0cdf09..a9b9358ef0 100644 --- a/tests/topotests/bfd_topo2/test_bfd_topo2.py +++ b/tests/topotests/bfd_topo2/test_bfd_topo2.py @@ -144,7 +144,7 @@ def test_bfd_connection(): test_func = partial( topotest.router_json_cmp, router, "show bfd peers json", expected ) - _, result = topotest.run_and_expect(test_func, None, count=8, wait=0.5) + _, result = topotest.run_and_expect(test_func, None, count=30, wait=0.5) assertmsg = '"{}" JSON output mismatches'.format(router.name) assert result is None, assertmsg