mirror_edk2/MdeModulePkg/Universal/Disk
Laszlo Ersek a3240c63ec MdeModulePkg/UdfDxe: ASSERT() valid ReadFileInfo Flags for INLINE_DATA req
In the ReadFile() function, if "RecordingFlags" is INLINE_DATA, then we
cover the following values of "ReadFileInfo->Flags":

- READ_FILE_GET_FILESIZE
- READ_FILE_ALLOCATE_AND_READ
- READ_FILE_SEEK_AND_READ

We don't do anything (just proceed to the end of the function) if
"ReadFileInfo->Flags" is anything else.

In reality the above three values cover the domain of the
UDF_READ_FILE_FLAGS enum type fully, and "ReadFileInfo->Flags" is only
ever set internally to UdfDxe. Therefore any other flag value would be a
bug in UdfDxe.

ASSERT() specifically that "ReadFileInfo->Flags" has been set correctly,
so that the reader is not left wondering what happens if none of the enum
constants match.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Paulo Alcantara <pcacjr@zytor.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Paulo Alcantara <pcacjr@zytor.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
2017-09-12 12:12:18 +02:00
..
CdExpressPei MdeModulePkg/CdExpressPei: Use PcdRecoveryFileName PCD. 2016-10-12 09:15:23 +08:00
DiskIoDxe MdeModulePkg DiskIoDxe: Media status check not be done at DiskIo level 2016-03-29 13:39:13 +08:00
PartitionDxe MdeModulePkg/PartitionDxe: Initialize the array after declaration 2017-09-12 17:22:07 +08:00
RamDiskDxe MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages 2017-03-20 11:06:36 +01:00
UdfDxe MdeModulePkg/UdfDxe: ASSERT() valid ReadFileInfo Flags for INLINE_DATA req 2017-09-12 12:12:18 +02:00
UnicodeCollation/EnglishDxe MdeModulePkg: Convert all .uni files to utf-8 2015-12-15 04:56:23 +00:00