proxmox-mirrors/mirror_edk2
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_edk2 synced 2026-01-23 21:40:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
3dbf922901
mirror_edk2/ShellPkg/Library
History
Laszlo Ersek 3dbf922901 ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with decl. 
"Compress.h" declares the Compress() function as EFIAPI, but the
definition in "Compress.c" lacks EFIAPI.

GCC toolchains without LTO do not catch this error because "Compress.c"
does not include "Compress.h"; i.e. the declaration used by callers such
as "EfiCompress.c" is not actually matched against the function definition
at build time.

With LTO enabled, the mismatch is found -- however, as a warning only, due
to commit f8d0b96629 ("BaseTools GCC5: disable warnings-as-errors for
now", 2016-08-03).

Include the header in the C file (which turns the issue into a hard build
error on all GCC toolchains), plus sync the declaration from the header
file to the C file. Finally, remove EFIAPI from both declaration and
definition -- this was the original intent of commit c4e74e9b81
("ShellPkg/UefiShellDebug1CommandsLib: Remove unnecessary EFIAPI",
2016-10-09), but it missed the header file.

(Gary meant to address that omission in Oct 2017:

  [edk2] [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove EFIAPI from
                 Compress()

  http://mid.mail-archive.com/20171026065329.32311-1-glin@suse.com

and Ray reviewed the patch, but then the patch was never committed.)

So do the sync and drop EFIAPI now.

This happens to fix the EFICOMPRESS shell command, when built with GCC for
X64.

Cc: Gary Lin <glin@suse.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Fixes: c4e74e9b81
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Gary Lin <glin@suse.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
2018-02-08 18:21:11 +01:00
..
UefiHandleParsingLib ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo 2017-11-08 13:06:16 +08:00
UefiShellBcfgCommandLib ShellPkg: Fix misuses of AllocateCopyPool 2017-11-08 17:13:04 +08:00
UefiShellCEntryLib ShellPkg: Fix typos in comments and variables 2016-11-15 11:05:34 +08:00
UefiShellCommandLib ShellPkg/CommandLib: Locate proper UnicodeCollation instance 2018-01-29 09:41:44 +08:00
UefiShellDebug1CommandsLib ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with decl. 2018-02-08 18:21:11 +01:00
UefiShellDriver1CommandsLib ShellPkg/disconnect: '-r' is not optional when disconnecting all 2017-09-29 15:19:10 +08:00
UefiShellInstall1CommandsLib Revert "ShellPkg : Add UEFI_APPLICATION module type to UefiShellInstall1CommandsLib.inf" 2016-01-06 16:23:20 +00:00
UefiShellLevel1CommandsLib ShellPkg/for: Fix potential null pointer deference 2018-02-06 17:30:24 +08:00
UefiShellLevel2CommandsLib ShellPkg/map: Fix out-of-bound read when "map fsn" 2018-02-06 17:31:16 +08:00
UefiShellLevel3CommandsLib ShellPkg/UefiShellLevel3CommandsLib: fix string over-read 2018-01-25 10:24:21 +08:00
UefiShellLib ShellPkg/ShellLib: Fix dynamic command fails to start during boot 2017-11-29 10:31:54 +08:00
UefiShellNetwork1CommandsLib ShellPkg: Update Api from NetLibDetectMedia to NetLibDetectMediaWaitTimeout. 2017-12-18 16:38:24 +08:00
UefiShellNetwork2CommandsLib ShellPkg: Fix a build error in Ping6 shell command. 2017-12-18 17:52:02 +08:00