mirror of
https://git.proxmox.com/git/mirror_edk2
synced 2025-12-26 16:02:15 +00:00
27daa8658e
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=699 Within function AhciModeInitialization(), left shift operations of 'BIT0' in the following statements: "if ((PortImplementBitMap & (BIT0 << Port)) != 0) {" will incur possible out of range left shift when Port is 31, since "1 << 31" is possible to exceed the range of type 'int' (signed). According to the C11 spec, Section 6.5.7: > 4 The result of E1 << E2 is E1 left-shifted E2 bit positions; vacated > bits are filled with zeros. If E1 has an unsigned type, the value > of the result is E1 * 2^E2 , reduced modulo one more than the > maximum value representable in the result type. If E1 has a signed > type and nonnegative value, and E1 * 2^E2 is representable in the > result type, then that is the resulting value; otherwise, the > behavior is undefined. This commit explicitly cast 'BIT0' with UINT32 to resolve this issue. Cc: Steven Shi <steven.shi@intel.com> Cc: Eric Dong <eric.dong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu <hao.a.wu@intel.com> Reviewed-by: Star Zeng <star.zeng@intel.com> |
||
|---|---|---|
| .. | ||
| AhciMode.c | ||
| AhciMode.h | ||
| AtaAtapiPassThru.c | ||
| AtaAtapiPassThru.h | ||
| AtaAtapiPassThru.inf | ||
| AtaAtapiPassThruDxe.uni | ||
| AtaAtapiPassThruDxeExtra.uni | ||
| ComponentName.c | ||
| IdeMode.c | ||
| IdeMode.h | ||