proxmox-mirrors/mirror_edk2
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_edk2 synced 2025-10-26 21:33:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
22,918 Commits 1 Branch 18 Tags 309 MiB
fee5ea2c84
Commit Graph

151 Commits

Author SHA1 Message Date
Qiu Shumin
427d61ad4a ShellPkg: Refine code style to avoid potential NullPointer dereference. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Ni Ruiyu <ruiyu.ni@intel.com>



git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16161 6f19259b-4bc3-4df7-8a09-765794883524
 2014-09-23 06:20:59 +00:00
Ni Ruiyu
a6e84d95f5 ShellPkg: ShellPkg: Fix the cp fail while coping directory. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ni Ruiyu <ruiyu.ni@intel.com>
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16148 6f19259b-4bc3-4df7-8a09-765794883524
 2014-09-19 01:39:45 +00:00
Qiu Shumin
715096c244 ShellPkg: Refine code style to avoid potential uninitialized local variable. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16146 6f19259b-4bc3-4df7-8a09-765794883524
 2014-09-19 01:32:05 +00:00
Qiu Shumin
0960ba17e5 ShellPkg: Remove redundant quotes in file path string for Shell command parameters. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16122 6f19259b-4bc3-4df7-8a09-765794883524
 2014-09-17 07:58:31 +00:00
Jaben Carsey
5a51ad8d20 Updates the logic to allow RM and CP to have silent/quiet mode work successfully. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16056 6f19259b-4bc3-4df7-8a09-765794883524
 2014-09-03 17:44:53 +00:00
Jaben Carsey
81957f8dfc This patch replaces StrCpy with StrnCpy or refactors out the usage of StrCpy through some other means. 
This patch replaces StrCat with StrnCat or refactors out the usage of StrCat through some other means.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16002 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-29 21:17:27 +00:00
Tapan Shah
288638f0aa Add CTRL+C support for ‘attrib’ command. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com>
Reviewed-By: Jaben Carsey <jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15991 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-29 20:32:15 +00:00
Tapan Shah
078308324f Cleanup UefiShellLevel2CommandsLib commands help output string to : 
* Follow a consistent style
  * Add consistent sections: NOTES, EXAMPLES, RETURN VALUES, etc.
  * Wrap the text to fit in 80x25 formatted console output

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com>
Reviewed-By: Jaben Carsey <jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15990 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-29 20:30:58 +00:00
Tapan Shah
8a3146d46c Add CTRL+C support for ‘ls’ command. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com>
Reviewed-By: Jaben Carsey <jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15989 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-29 20:24:58 +00:00
Tapan Shah
9b5268c8f7 Add new aliases called ‘move’ and ‘mount’ for ‘mv’ and ‘map’ commands respectively. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com>
Reviewed-By: Jaben Carsey <jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15988 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-29 20:22:48 +00:00
Tapan Shah
41921ad5c3 ShellPkg: Fix ‘ren’ alias for ‘mv’ command. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15974 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-28 19:56:08 +00:00
Jaben Carsey
cea5e3b9bf ShellPkg: Refactor string manipulation 
This patch replaces StrCpy with StrnCpy or refactors out the usage of StrCpy through some other means.
This patch replaces StrCat with StrnCat or refactors out the usage of StrCat through some other means.


Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15882 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-22 16:06:55 +00:00
Chris Phillips
78d42190ce ShellPkg: Fixes and updates for the 'parse' command 
- Fix SFO file parsing to match UEFI Shell 2.1 spec
- Update help output for easier viewing

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15873 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-21 20:28:32 +00:00
Chris Phillips
53715dcd50 ShellPkg: Fix 'ls -sfo' and 'map -sfo' output format to match UEFI Shell 2.1 spec 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15869 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-21 19:59:49 +00:00
Qiu Shumin
30cad98e5f ShellPkg: Fix typo in 'uni' files. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15842 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-20 01:20:53 +00:00
Chris Phillips
deb21fd0ea ShellPkg: Fixes for timezone handling and 'date -sfo' 
- Update 'date -sfo' format to match UEFI Shell 2.1 spec
- Fixes to correctly initialize Second
- Set correct sign when setting timezone with the 'time -tz' command.  Now matches UEFI spec calculation of "Localtime = UTC - TimeZone"
- Display "LOCAL" when TimeZone == EFI_UNSPECIFIED_TIMEZONE
- Allow a timezone of '_local' to be provided by user
- Better invalid command line checking

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15840 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-19 23:05:44 +00:00
Jaben Carsey
e1044f8074 ShellPkg: Refactor string manipulation in cp command 
This patch replaces StrCpy with StrnCpy or refactors out the usage of StrCpy through some other means.
This patch replaces StrCat with StrnCat or refactors out the usage of StrCat through some other means.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15771 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-07 20:02:40 +00:00
Jaben Carsey
a737ea734b Updates the logic to allow RM and CP to have silent/quiet mode work successfully. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Lee Rosenbaum <lee.g.rosenbaum@intel.com> 

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15755 6f19259b-4bc3-4df7-8a09-765794883524
 2014-08-05 20:55:36 +00:00
Eric Dong
0d807dae4a Update code to support VS2013 tool chain. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15704 6f19259b-4bc3-4df7-8a09-765794883524
 2014-07-29 02:00:55 +00:00
Chris Phillips
83c7a556a2 ShellPkg: Fix 'mv' command to not attempt moving a file from write-protected media 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15584 6f19259b-4bc3-4df7-8a09-765794883524
 2014-06-24 18:39:15 +00:00
Tapan Shah
e71cb45263 ShellPkg: Move UpdateMapping() out of Map command and added to UefiShellCommandLib library. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15580 6f19259b-4bc3-4df7-8a09-765794883524
 2014-06-23 18:36:44 +00:00
Qiu Shumin
022ed0d788 Use a compare operator for Non-Boolean comparison in 'map.c'. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben carsey <Jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15559 6f19259b-4bc3-4df7-8a09-765794883524
 2014-06-06 08:47:18 +00:00
Jaben Carsey
f747c71e30 ShellPkg: fix display for map command with filtering 
This patch correctly displays map information when a filter was applied such as “map fs*” or “map f*”, including the use of “-c” to display the consist names first in this situation.

It also moves a statement from both clauses of an “if/else” to above the “if” statement for efficiency.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Tapan Shah <tapandshah@hp.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15548 6f19259b-4bc3-4df7-8a09-765794883524
 2014-05-28 17:31:22 +00:00
Jaben Carsey
7282b505c5 ShellPkg: Add error messages to CP when destination file or directory cannot be opened/created 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Tapan Shah <tapandshah@hp.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15530 6f19259b-4bc3-4df7-8a09-765794883524
 2014-05-14 16:55:56 +00:00
Shumin Qiu
4f344fffc7 1.Add code to check the pointer 'CorrectedPath' in Ls.c line 460 before referenced. 2.Not use explicit comparisons to TRUE or FALSE for Boolean variable in Ls.c. 3.Add doxygen tags in comment and return type for 'ToLower' in ShellProtocol.c. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15320 6f19259b-4bc3-4df7-8a09-765794883524
 2014-03-07 01:06:37 +00:00
Shumin Qiu
3a8406adb3 Add code to check whether the pointer 'CorrectedPath' and 'FullPath' are NULL before used. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15260 6f19259b-4bc3-4df7-8a09-765794883524
 2014-02-25 08:30:32 +00:00
Jaben Carsey
929fb3be41 ShellPkg: Update "ls" command to better handle "-r" parameter 
This makes sure that recursion into sub directories looks through all subdirectories, not just those that match the initial search pass.  Also only prints out any information for directories in which at least one matching file is found.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.Carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15250 6f19259b-4bc3-4df7-8a09-765794883524
 2014-02-18 21:53:00 +00:00
Shumin Qiu
f3a14a0f57 Add code to check the return status for ShellReadFile and ShellWriteFile when execute the 'cp' command. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15231 6f19259b-4bc3-4df7-8a09-765794883524
 2014-02-12 01:52:27 +00:00
Jaben Carsey
1eb5cf94a1 ShellPkg: Prevent "set" command from updating %lasterror% 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.Carsey@intel.com>
reviewed-by: Laurie Jarlstrom <laurie.jarlstrom@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15219 6f19259b-4bc3-4df7-8a09-765794883524
 2014-02-11 20:36:05 +00:00
Shumin Qiu
7bc3ec3d80 1. Fix several comments in function headers for 'ShellProtocol.c', 'ShellProtocol.h' and 'Ls.c'. 2. Remove the initialization of variable 'CalleeExitStatus' in function 'RunScriptFileHandle' of 'Shell.c' from its declarartion. 
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15190 6f19259b-4bc3-4df7-8a09-765794883524
 2014-01-28 00:37:11 +00:00
Jaben Carsey
fed3be946c ShellPkg: Refactor Print logic out of main loop function 
This has no change in the behavior of the LS command, but it removes the printing logic from the main recursive function.  This is the first step toward changing the code flow without affecting the look and feel.

The long term goal is correcting the recursion to be more clean and useful to users.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15179 6f19259b-4bc3-4df7-8a09-765794883524
 2014-01-24 20:33:17 +00:00
Jaben Carsey
012305d551 ShellPkg: remove double free operation 
This pointer gets free twice and this does not work.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15094 6f19259b-4bc3-4df7-8a09-765794883524
 2014-01-10 16:41:54 +00:00
Shumin Qiu
c6cef63532 Update code to ensure the pointer ‘CurrentName’ in function ‘PerformSingleMappingDisplay’ isn’t null before being processed. 
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14990 6f19259b-4bc3-4df7-8a09-765794883524
 2013-12-17 01:04:38 +00:00
Jaben Carsey
3520e03f3d ShellPkg: Remove invalid ASSERT 
There was an assumption that this API would never fail.  That is not true and the return value is checked just a few lines later.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14951 6f19259b-4bc3-4df7-8a09-765794883524
 2013-12-09 23:00:21 +00:00
Jaben Carsey
64a5bae21f ShellPkg: Correctly support "map -c" 
When “map –c” is run, the mapped items should be displayed with the consistent name as the one listed to the left and all other names listed as “alias(s)”

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Chris Phillips <chrisp@hp.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14881 6f19259b-4bc3-4df7-8a09-765794883524
 2013-11-21 22:51:52 +00:00
Chris Phillips
c32ad35161 ShellPkg: Fix for the ‘mv’ command when destination starts with ‘\’. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com>
reviewed-by: Jaben Carsey <jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14787 6f19259b-4bc3-4df7-8a09-765794883524
 2013-10-18 20:10:18 +00:00
Chris Phillips
58b7301ec9 ShellPkg: Fixes for the ‘ls’ command: 
- Better output to print header and file not found text
- Fix file attribute argument handling
- Fix so path ending with ‘\’ or ‘*’ is handled correctly

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com>
reviewed-by: Jaben Carsey <jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14786 6f19259b-4bc3-4df7-8a09-765794883524
 2013-10-18 18:53:16 +00:00
Olivier Martin
5051c2873b ShellPkg: Fixed build errors related to variable declarations 
- variable "TempLocation" was set but never used

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>



git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14605 6f19259b-4bc3-4df7-8a09-765794883524
 2013-08-27 09:01:54 +00:00
Jaben Carsey
9f56625f2a ShellPkg: Fix potentially uninitialized variable compiler warning 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14598 6f19259b-4bc3-4df7-8a09-765794883524
 2013-08-23 15:21:16 +00:00
Jaben Carsey
ac8783c8b1 ShellPkg: Fix file size error upon copy operation. 
There was a case where an copy operation of a small file overwriting a larger file would not correctly remove the extra space in the old file.  The resultant file would have the entire source file and then what remained of the original file.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
reviewed-by: El-Haj-Mahmoud, Samer <samer.el-haj-mahmoud@hp.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14584 6f19259b-4bc3-4df7-8a09-765794883524
 2013-08-21 17:32:16 +00:00
Eugene Cohen
433a21cba1 ShellPkg: increase available size for PcdShellFileOperationSize 
Some storage subsystems benefit by having shell file operation sizes (affecting copy and type commands right now) larger than 2^16.  This patch changes the PcdShellFileOperationSize type to 32-bits.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen <eugene@hp.com>
reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14534 6f19259b-4bc3-4df7-8a09-765794883524
 2013-08-08 22:31:54 +00:00
Ruiyu Ni
863986b3c8 Update all the code to consume the ConvertDevicePathToText, ConvertDevicePathNodeToText, ConvertTextToDevicePath and ConvertTextToDeviceNode APIs in DevicePathLib. 
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Elvin Li <elvin.li@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Guo Dong <guo.dong@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14505 6f19259b-4bc3-4df7-8a09-765794883524
 2013-07-26 03:14:08 +00:00
Jaben Carsey
75a68c6969 ShellPkg: remove high bit to change a EFI_STATUS to a SHELL_STATUS 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14484 6f19259b-4bc3-4df7-8a09-765794883524
 2013-07-18 15:36:55 +00:00
Gary Ching-Pang Lin
73c5c61904 ShellPkg: Update error to be SHELL_STATUS and not EFI_STATUS. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Ching-Pang Lin <glin@suse.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14475 6f19259b-4bc3-4df7-8a09-765794883524
 2013-07-16 14:40:57 +00:00
jaben carsey
7461437cf1 ShellPkg: Verify memory and handle allocation failure. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: jaben carsey <jaben.carsey@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14448 6f19259b-4bc3-4df7-8a09-765794883524
 2013-06-28 22:44:21 +00:00
Jaben Carsey
22feb630eb ShellPkg: Update rm command to properly prepend file system identifiers to filenames. 
This is required when recursively removing directories with files on file systems other than the current one.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Eugene Cohen <eugene@hp.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14441 6f19259b-4bc3-4df7-8a09-765794883524
 2013-06-21 21:20:03 +00:00
jcarsey
28981267c5 ShellPkg: Fix ARM build errors. 
submitted-by: Olivier Martin olivier.martin@arm.com>
reviewed-by: Jaben Carsey <Jaben.Carsey@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14400 6f19259b-4bc3-4df7-8a09-765794883524
 2013-06-11 22:07:03 +00:00
Eric Dong
ed053afece ShellPkg: refine the logic for cp command 
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <Erik.c.Bjorge@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14394 6f19259b-4bc3-4df7-8a09-765794883524
 2013-06-04 01:06:22 +00:00
lgao4
cbcccd2c9d Update Code to pass EBC compiler. 
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14352 6f19259b-4bc3-4df7-8a09-765794883524
 2013-05-13 02:36:09 +00:00
jcarsey
391206e775 ShellPkg: Update behavior for GetTime() errors. 
Please find the attached patch that fixes the ShellPkg when gRT->GetTime() returns an error (eg: early UEFI platform bringup with a RTC controller that is not supported).
On some platforms, gRT->GetTime() might not return EFI_SUCCESS. The Shell must check the return status before to assume the returned time is valid.


Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <Olivier.Martin@arm.com>
Reviewed-by: Jaben Carsey <Jaben.Carsey@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14337 6f19259b-4bc3-4df7-8a09-765794883524
 2013-05-09 16:18:58 +00:00
jcarsey
e755a4ca10 ShellPkg: Fixed build error 'variable set but not used' 
GCC toolchain cannot build ShellPkg.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Harry Liebel <Harry.Liebel@arm.com>
Signed-off-by: Olivier Martin <Olivier.Martin@arm.com>
Reviewed-by: Jaben Carsey <Jaben.Carsey@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14326 6f19259b-4bc3-4df7-8a09-765794883524
 2013-05-07 17:57:58 +00:00
jcarsey
0290177adf ShellPkg: explicitly prevent dereferencing pointer 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
reviewed-by: Erik Bjorge <Erik.c.Bjorge@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14291 6f19259b-4bc3-4df7-8a09-765794883524
 2013-04-18 16:05:59 +00:00
jcarsey
f06be00e7a ShellPkg: Fixes CP function to prevent copying of files if destination does not have adequate storage. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Matt Stanbro <Matthew.A.Stanbro@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14203 6f19259b-4bc3-4df7-8a09-765794883524
 2013-03-12 20:56:36 +00:00
jcarsey
7dd0562309 ShellPkg : Check pointer before dereferencing 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14144 6f19259b-4bc3-4df7-8a09-765794883524
 2013-02-22 18:20:55 +00:00
jcarsey
54c9a68d9c ShellPkg: fix string truncation. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14129 6f19259b-4bc3-4df7-8a09-765794883524
 2013-02-14 01:02:15 +00:00
jcarsey
668a5781d3 ShellPkg: add verification that a target directory exists when changing directory with drive identifier. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14128 6f19259b-4bc3-4df7-8a09-765794883524
 2013-02-13 22:22:16 +00:00
jcarsey
d51088b764 ShellPkg: Updates to 'help' command 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com>
reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13997 6f19259b-4bc3-4df7-8a09-765794883524
 2012-12-13 21:26:22 +00:00
jcarsey
60448d9b8d ShellPkg: Fix en-US characters that are outside the Basic Latin character set range 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud elhaj@hp.com 
reviewed-by: Jaben Carsey jaben.carsey@intel.com

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13448 6f19259b-4bc3-4df7-8a09-765794883524
 2012-06-12 17:22:19 +00:00
jcarsey
74fa83fda6 ShellPkg: fix 'ls' handling of empty drives where there is not even an "." or ".." directory. 
Signed-off-by: jcarsey
Reviewed-by: winddy_zhang@byosoft.com.cn

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12981 6f19259b-4bc3-4df7-8a09-765794883524
 2012-02-02 16:55:30 +00:00
jcarsey
a32980dd3c ShellPkg: Fix rm CWD protection to be better at catching similarly named directories. 
signed-off-by: jcarsey
reviewed-by: geekboy15a

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12950 6f19259b-4bc3-4df7-8a09-765794883524
 2012-01-20 18:10:45 +00:00
jcarsey
a7224eefeb ShellPkg: Check for Abort flag in main 'for' loop of ls command and propagate the condition when found. 
Also prevents printing of an error output when user selects abort.

signed-off-by: jcarsey
reviewed-by: 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12925 6f19259b-4bc3-4df7-8a09-765794883524
 2012-01-11 18:45:23 +00:00
jcarsey
344b16e151 ShellPkg: fix copyright date. 
signed-off-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12911 6f19259b-4bc3-4df7-8a09-765794883524
 2012-01-05 20:46:16 +00:00
jcarsey
d8fdd5247c ShellPkg: Fix swapping of reset behavior. 
This fix exchanges the behavior between "reset -c" and "reset" with "reset -w".

signed-off-by: jliu66
reviewed-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12909 6f19259b-4bc3-4df7-8a09-765794883524
 2012-01-05 18:20:23 +00:00
jcarsey
8fcf74a850 ShellPkg: print error when column index is out of range instead of ASSERT. 
signed-off-by: jcarsey
reviewed-by: leegrosenbaum

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12904 6f19259b-4bc3-4df7-8a09-765794883524
 2012-01-02 21:17:20 +00:00
jcarsey
8f04ca1a8f ShellPkg: Fix "-b" usage with timezone command. 
signed-off-by: jcarsey
reviewed-by: geekboy15a

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12799 6f19259b-4bc3-4df7-8a09-765794883524
 2011-11-29 21:46:53 +00:00
jcarsey
73c83c69c0 ShellPkg: Correct incorrect use of sizeof to use macro for EFI_FILE_INFO size. 
Signed-off-by: jcarsey
Reviewed-by: niruiyu


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12740 6f19259b-4bc3-4df7-8a09-765794883524
 2011-11-18 17:02:36 +00:00
jcarsey
3372840669 ShellPkg: swap warm and cold to get the default correct for Reset command. 
sighed-off-by: jcarsey
reviewed-by: gookboy15a

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12623 6f19259b-4bc3-4df7-8a09-765794883524
 2011-11-01 20:05:11 +00:00
ydong10
d6c06dd776 Fix a code typo. 
Signed-off-by: ydong10

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12543 6f19259b-4bc3-4df7-8a09-765794883524
 2011-10-18 01:47:53 +00:00
jcarsey
c8c2259156 ShellPkg: Add checking for memory allocation and pointer returns from functions. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12542 6f19259b-4bc3-4df7-8a09-765794883524
 2011-10-17 17:49:21 +00:00
jcarsey
532691c8ba ShellPkg: Add checking for memory allocation and pointer returns from functions. 
signed-off-by: jcarsey
reviewed-by: geekboy15a

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12540 6f19259b-4bc3-4df7-8a09-765794883524
 2011-10-14 19:21:13 +00:00
jcarsey
beab0fc5e2 ShellPkg: Verify memory allocations without ASSERT. 
signed-off-by: jcarsey
reviewed-by: geekboy15a

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12522 6f19259b-4bc3-4df7-8a09-765794883524
 2011-10-10 17:26:25 +00:00
lgao4
bca163ff11 Clean up the private GUID definition in module Level. 
Signed-off-by: lgao4
Reviewed-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12394 6f19259b-4bc3-4df7-8a09-765794883524
 2011-09-21 01:56:00 +00:00
jcarsey
1fc3749dad ShellPkg: fix support for "\" (or "\.") meaning root of drive. 
Cp command fixed to allow for copying single or multiple files to the root of the drive with destination directory \.
Cd command fixed to allow for changing CWD to the root of the drive with destination directory \.

signed-off-by: jcarsey
reviewed-by: geekboy15a

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12392 6f19259b-4bc3-4df7-8a09-765794883524
 2011-09-20 21:01:34 +00:00
ydong10
4ff7e37b4f Refine comments and two code style. 
Signed-off-by: ydong10

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12263 6f19259b-4bc3-4df7-8a09-765794883524
 2011-09-02 08:05:34 +00:00
jcarsey
ab94587a7d This refactors 3 functions out of ShellCommandLib and puts them into a new library (but as 2 functions instead of 3). This allows for users outside of the shell itself to have access to these functions. 
1) Remove the 3 functions out of the shell's internal library (ShellCommandLib)
2) Add a new library class (PathLib)
3) Add an instance of this class (BasePathLib)
4) Change all internal shell callers to use this new library class.

signed-off-by: jcarsey
reviewed-by: jljusten

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11936 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-30 22:58:53 +00:00
jcarsey
f1518f6970 add fixes for code verification happyness. 
signed-off-by: jcarsey
reviewed-by: jljusten

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11935 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-30 22:25:46 +00:00
jcarsey
35f26e73cc replace assert with error. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11897 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-27 20:28:23 +00:00
jcarsey
2e8e9ed5ed Remove ASSERT within Ls for RTC error and associated changes. 
TimeDate.c: replace magic number with constant.
Ls.c: use new warning printout string and remove an ASSERT.  also replace magic number with constant.
The UNI file: add new warning printout string.

Signed-off-by: jcarsey
Reviewed-by: geekboy15a
Reviewed-by: lgrosenb


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11703 6f19259b-4bc3-4df7-8a09-765794883524
 2011-05-25 22:29:40 +00:00
jcarsey
77dd0c814e Clarify an error in Map command. 
Revert a change in Map command that affected some consistent map names being printed correctly.
Fix a library instance mapping in DSC.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11675 6f19259b-4bc3-4df7-8a09-765794883524
 2011-05-17 20:32:47 +00:00
jcarsey
82571fb5d1 add support to easily remove profiles and shell levels. the libraries will not do anything (but no longer fail), if the PCDs are changed to remove their functionality. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11666 6f19259b-4bc3-4df7-8a09-765794883524
 2011-05-16 22:12:20 +00:00
jcarsey
f20076daaf fix user input validation for time command. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11567 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-19 16:55:51 +00:00
jcarsey
eef1ed4638 rm - refine user input validation to prevent removal of CWD. 
change colors of "set" command output.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11538 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-13 23:37:21 +00:00
jcarsey
a49016b117 move a function to the correct library. 
added "ren" as an alias for "mv"

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11537 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-13 23:35:59 +00:00
jcarsey
a1d4bfcc3f add comments to function declarations and definitions and updated to match coding style document. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11505 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-05 20:55:45 +00:00
jcarsey
cbdd109b43 check memory allocations for success. 
check pointer before access.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11503 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-04 21:41:24 +00:00
jcarsey
ae724571be Comment's added and fixed. 
Pointer's checked for NULL before access and after memory allocations.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11499 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-01 22:16:01 +00:00
jcarsey
b2bf973586 fix for the cp shell command - halt when an error was encountered and also fix the error message displayed. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11462 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-30 21:37:01 +00:00
jcarsey
33c031ee20 pointer verification (not NULL) and buffer overrun fixes. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11459 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-30 19:33:03 +00:00
jcarsey
6b825919f1 add more user input verification to connect and vol commands. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11458 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-30 16:36:42 +00:00
jcarsey
2ec013ce0f clarify error message when listing files based on a metaname without a current working directory. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11450 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-29 20:19:51 +00:00
jcarsey
0841f3af8c fix changing time daylight settings without changing the time. 
add extra output for daylight setting.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11449 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-29 19:59:37 +00:00
jcarsey
e35b531794 prevents "" from being the result of trying to open the root of a drive. 
more input validation on vol command.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11444 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-28 21:49:17 +00:00
jcarsey
590c3cb14a cp - fix conditional for memory de-allocaiton. 
string file - fix copyright date.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11443 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-28 18:42:51 +00:00
jcarsey
b54fd049bd Cd - add more input verification. 
Cp - support "\" as root of drive indicator.
Load - invert "-nc" to not connect.
Ls - ignore archive file attribute.
Map - add more input verification.  fix add by handle.
Mv - support overwrite question. support "\" as root of drive indicator.
Parse - add comments.
Rm - add comments.
TimeDate - add more input verification. add comments.
Vol - add new command.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11426 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 20:58:08 +00:00
jcarsey
c154b99708 fixes for NULL verification. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11125 6f19259b-4bc3-4df7-8a09-765794883524
 2010-12-06 18:10:34 +00:00
jcarsey
3e082d5826 Verify more memory allocations. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10910 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:44:57 +00:00
jcarsey
9ea69f8a05 Verify memory allocations were successful. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10909 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:30:40 +00:00
jcarsey
d38a107995 change the en-dash to the standard dash character. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10908 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:29:30 +00:00
jljusten
e97233217e ShellPkg: Fix several GCC compiler warnings 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10890 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-17 20:09:48 +00:00
hhtian
fbec9c0f1c copyright format update 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10875 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-14 12:22:42 +00:00