mirror of
				https://git.proxmox.com/git/mirror_edk2
				synced 2025-11-04 03:52:45 +00:00 
			
		
		
		
	SecurityPkg: Add TPM PTP detection in Tpm12SubmitCommand.
Previously, we only add PTP detection in Tpm12RequestUseTpm, because RequestUseTpm does not check TPM command. This patch also adds similar check in Tpm12SubmitCommand. PTP device does not accept TPM12 command, so that it can return error on PTP device, instead of wait till timeout. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" <jiewen.yao@intel.com> Reviewed-by: "Zhang, Chao B" <chao.b.zhang@intel.com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19755 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
		
							parent
							
								
									1a4acc1136
								
							
						
					
					
						commit
						e4780913e5
					
				@ -57,6 +57,44 @@ Tpm12TisPcPresenceCheck (
 | 
			
		||||
  return (BOOLEAN)(RegRead != (UINT8)-1);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
/**
 | 
			
		||||
  Return PTP interface type.
 | 
			
		||||
 | 
			
		||||
  @param[in] Register                Pointer to PTP register.
 | 
			
		||||
 | 
			
		||||
  @return PTP interface type.
 | 
			
		||||
**/
 | 
			
		||||
PTP_INTERFACE_TYPE
 | 
			
		||||
Tpm12GetPtpInterface (
 | 
			
		||||
  IN VOID *Register
 | 
			
		||||
  )
 | 
			
		||||
{
 | 
			
		||||
  PTP_CRB_INTERFACE_IDENTIFIER  InterfaceId;
 | 
			
		||||
  PTP_FIFO_INTERFACE_CAPABILITY InterfaceCapability;
 | 
			
		||||
 | 
			
		||||
  if (!Tpm12TisPcPresenceCheck (Register)) {
 | 
			
		||||
    return PtpInterfaceMax;
 | 
			
		||||
  }
 | 
			
		||||
  //
 | 
			
		||||
  // Check interface id
 | 
			
		||||
  //
 | 
			
		||||
  InterfaceId.Uint32 = MmioRead32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId);
 | 
			
		||||
  InterfaceCapability.Uint32 = MmioRead32 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->InterfaceCapability);
 | 
			
		||||
 | 
			
		||||
  if ((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_CRB) &&
 | 
			
		||||
      (InterfaceId.Bits.InterfaceVersion == PTP_INTERFACE_IDENTIFIER_INTERFACE_VERSION_CRB) &&
 | 
			
		||||
      (InterfaceId.Bits.CapCRB != 0)) {
 | 
			
		||||
    return PtpInterfaceCrb;
 | 
			
		||||
  }
 | 
			
		||||
  if ((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_FIFO) &&
 | 
			
		||||
      (InterfaceId.Bits.InterfaceVersion == PTP_INTERFACE_IDENTIFIER_INTERFACE_VERSION_FIFO) &&
 | 
			
		||||
      (InterfaceId.Bits.CapFIFO != 0) &&
 | 
			
		||||
      (InterfaceCapability.Bits.InterfaceVersion == INTERFACE_CAPABILITY_INTERFACE_VERSION_PTP)) {
 | 
			
		||||
    return PtpInterfaceFifo;
 | 
			
		||||
  }
 | 
			
		||||
  return PtpInterfaceTis;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
/**
 | 
			
		||||
  Check whether the value of a TPM chip register satisfies the input BIT setting.
 | 
			
		||||
 | 
			
		||||
@ -393,51 +431,30 @@ Tpm12SubmitCommand (
 | 
			
		||||
  IN UINT8             *OutputParameterBlock
 | 
			
		||||
  )
 | 
			
		||||
{
 | 
			
		||||
  return Tpm12TisTpmCommand (
 | 
			
		||||
           (TIS_PC_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress),
 | 
			
		||||
           InputParameterBlock,
 | 
			
		||||
           InputParameterBlockSize,
 | 
			
		||||
           OutputParameterBlock,
 | 
			
		||||
           OutputParameterBlockSize
 | 
			
		||||
           );
 | 
			
		||||
}
 | 
			
		||||
  PTP_INTERFACE_TYPE  PtpInterface;
 | 
			
		||||
 | 
			
		||||
/**
 | 
			
		||||
  Return PTP interface type.
 | 
			
		||||
 | 
			
		||||
  @param[in] Register                Pointer to PTP register.
 | 
			
		||||
 | 
			
		||||
  @return PTP interface type.
 | 
			
		||||
**/
 | 
			
		||||
PTP_INTERFACE_TYPE
 | 
			
		||||
Tpm12GetPtpInterface (
 | 
			
		||||
  IN VOID *Register
 | 
			
		||||
  )
 | 
			
		||||
{
 | 
			
		||||
  PTP_CRB_INTERFACE_IDENTIFIER  InterfaceId;
 | 
			
		||||
  PTP_FIFO_INTERFACE_CAPABILITY InterfaceCapability;
 | 
			
		||||
 | 
			
		||||
  if (!Tpm12TisPcPresenceCheck (Register)) {
 | 
			
		||||
    return PtpInterfaceMax;
 | 
			
		||||
  }
 | 
			
		||||
  //
 | 
			
		||||
  // Check interface id
 | 
			
		||||
  // Special handle for TPM1.2 to check PTP too, because PTP/TIS share same register address.
 | 
			
		||||
  //
 | 
			
		||||
  InterfaceId.Uint32 = MmioRead32 ((UINTN)&((PTP_CRB_REGISTERS *)Register)->InterfaceId);
 | 
			
		||||
  InterfaceCapability.Uint32 = MmioRead32 ((UINTN)&((PTP_FIFO_REGISTERS *)Register)->InterfaceCapability);
 | 
			
		||||
  PtpInterface = Tpm12GetPtpInterface ((VOID *) (UINTN) PcdGet64 (PcdTpmBaseAddress));
 | 
			
		||||
  switch (PtpInterface) {
 | 
			
		||||
  case PtpInterfaceFifo:
 | 
			
		||||
  case PtpInterfaceTis:
 | 
			
		||||
    return Tpm12TisTpmCommand (
 | 
			
		||||
             (TIS_PC_REGISTERS_PTR) (UINTN) PcdGet64 (PcdTpmBaseAddress),
 | 
			
		||||
             InputParameterBlock,
 | 
			
		||||
             InputParameterBlockSize,
 | 
			
		||||
             OutputParameterBlock,
 | 
			
		||||
             OutputParameterBlockSize
 | 
			
		||||
             );
 | 
			
		||||
  case PtpInterfaceCrb:
 | 
			
		||||
    //
 | 
			
		||||
    // No need to support CRB because it is only accept TPM2 command.
 | 
			
		||||
    //
 | 
			
		||||
  default:
 | 
			
		||||
    return EFI_DEVICE_ERROR;
 | 
			
		||||
  }
 | 
			
		||||
 | 
			
		||||
  if ((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_CRB) &&
 | 
			
		||||
      (InterfaceId.Bits.InterfaceVersion == PTP_INTERFACE_IDENTIFIER_INTERFACE_VERSION_CRB) &&
 | 
			
		||||
      (InterfaceId.Bits.CapCRB != 0)) {
 | 
			
		||||
    return PtpInterfaceCrb;
 | 
			
		||||
  }
 | 
			
		||||
  if ((InterfaceId.Bits.InterfaceType == PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_FIFO) &&
 | 
			
		||||
      (InterfaceId.Bits.InterfaceVersion == PTP_INTERFACE_IDENTIFIER_INTERFACE_VERSION_FIFO) &&
 | 
			
		||||
      (InterfaceId.Bits.CapFIFO != 0) &&
 | 
			
		||||
      (InterfaceCapability.Bits.InterfaceVersion == INTERFACE_CAPABILITY_INTERFACE_VERSION_PTP)) {
 | 
			
		||||
    return PtpInterfaceFifo;
 | 
			
		||||
  }
 | 
			
		||||
  return PtpInterfaceTis;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
/**
 | 
			
		||||
 | 
			
		||||
		Loading…
	
		Reference in New Issue
	
	Block a user