mirror of
https://git.proxmox.com/git/mirror_corosync
synced 2025-10-27 22:29:42 +00:00
e110080925
50:50 split algorithm now works in following way: - On client configuration change, membership change or disconnect wait till membership is stable (= all client configuration node list are equal, and all partitions has equal information). - Choose best partition >= 50% - If no such partition exists, send NACK to all clients - Send NACK to all clients who should receive NACK - After all clients who should receive NACK confirm vote reception, send ACK to all clients who should get ACK This ensures that there are never two partitions with ACK and it has much better behavior than previous version, because if tie-breaker partition is not connected, other partition gets ACK. Signed-off-by: Jan Friesse <jfriesse@redhat.com>
293 lines
8.5 KiB
C
293 lines
8.5 KiB
C
/*
|
|
* Copyright (c) 2015-2016 Red Hat, Inc.
|
|
*
|
|
* All rights reserved.
|
|
*
|
|
* Author: Jan Friesse (jfriesse@redhat.com)
|
|
*
|
|
* This software licensed under BSD license, the text of which follows:
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* - Redistributions of source code must retain the above copyright notice,
|
|
* this list of conditions and the following disclaimer.
|
|
* - Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
* - Neither the name of the Red Hat, Inc. nor the names of its
|
|
* contributors may be used to endorse or promote products derived from this
|
|
* software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
|
|
* THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <sys/types.h>
|
|
|
|
#include <string.h>
|
|
|
|
#include "qdevice-net-algo-ffsplit.h"
|
|
#include "qdevice-log.h"
|
|
#include "qdevice-net-send.h"
|
|
#include "qdevice-net-cast-vote-timer.h"
|
|
#include "qdevice-votequorum.h"
|
|
#include "utils.h"
|
|
|
|
static int
|
|
check_vqinfo_validity(struct qdevice_net_instance *instance)
|
|
{
|
|
struct qdevice_instance *qdev_instance;
|
|
struct votequorum_info vq_info;
|
|
cs_error_t cs_res;
|
|
struct node_list_entry *node;
|
|
uint32_t node_id;
|
|
|
|
qdev_instance = instance->qdevice_instance_ptr;
|
|
|
|
TAILQ_FOREACH(node, &qdev_instance->config_node_list, entries) {
|
|
node_id = node->node_id;
|
|
|
|
cs_res = votequorum_getinfo(qdev_instance->votequorum_handle, node_id, &vq_info);
|
|
|
|
if (cs_res == CS_ERR_NOT_EXIST) {
|
|
continue;
|
|
} else if (cs_res != CS_OK) {
|
|
qdevice_log(LOG_CRIT, "Can't get votequorum information for node "
|
|
UTILS_PRI_NODE_ID ". Error %s", node_id, cs_strerror(cs_res));
|
|
|
|
return (-1);
|
|
}
|
|
|
|
if (vq_info.node_votes != 1) {
|
|
qdevice_log(LOG_CRIT, "50:50 split algorithm works only if all nodes have "
|
|
"exactly 1 vote. Node " UTILS_PRI_NODE_ID " has %u votes!",
|
|
node_id, vq_info.node_votes);
|
|
|
|
return (-1);
|
|
}
|
|
|
|
if (vq_info.qdevice_votes != 1) {
|
|
qdevice_log(LOG_CRIT, "50:50 split algorithm works only if qdevice has "
|
|
"exactly 1 vote. Node "UTILS_PRI_NODE_ID" has %u votes!",
|
|
node_id, vq_info.qdevice_votes);
|
|
|
|
return (-1);
|
|
}
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
static int
|
|
check_cmap_validity(struct qdevice_net_instance *instance)
|
|
{
|
|
struct qdevice_instance *qdev_instance;
|
|
uint32_t qdevice_votes;
|
|
|
|
qdev_instance = instance->qdevice_instance_ptr;
|
|
|
|
if (cmap_get_uint32(qdev_instance->cmap_handle, "quorum.device.votes", &qdevice_votes) != CS_OK ||
|
|
qdevice_votes != 1) {
|
|
qdevice_log(LOG_CRIT, "50:50 split algorithm works only if quorum.device.votes"
|
|
" configuration key is set to 1!");
|
|
|
|
return (-1);
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_init(struct qdevice_net_instance *instance)
|
|
{
|
|
|
|
if (check_cmap_validity(instance) != 0 ||
|
|
check_vqinfo_validity(instance) != 0) {
|
|
return (-1);
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_connected(struct qdevice_net_instance *instance, int *send_config_node_list,
|
|
int *send_membership_node_list, int *send_quorum_node_list, enum tlv_vote *vote)
|
|
{
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_config_node_list_changed(struct qdevice_net_instance *instance,
|
|
const struct node_list *nlist, int config_version_set, uint64_t config_version,
|
|
int *send_node_list, enum tlv_vote *vote)
|
|
{
|
|
|
|
if (check_vqinfo_validity(instance) != 0) {
|
|
return (-1);
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_votequorum_node_list_notify(struct qdevice_net_instance *instance,
|
|
const struct tlv_ring_id *ring_id, uint32_t node_list_entries, uint32_t node_list[],
|
|
int *send_node_list, enum tlv_vote *vote)
|
|
{
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_votequorum_quorum_notify(struct qdevice_net_instance *instance,
|
|
uint32_t quorate, uint32_t node_list_entries, votequorum_node_t node_list[], int *send_node_list,
|
|
enum tlv_vote *vote)
|
|
{
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_votequorum_expected_votes_notify(struct qdevice_net_instance *instance,
|
|
uint32_t expected_votes, enum tlv_vote *vote)
|
|
{
|
|
|
|
if (check_vqinfo_validity(instance) != 0) {
|
|
return (-1);
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_config_node_list_reply_received(struct qdevice_net_instance *instance,
|
|
uint32_t seq_number, int initial, const struct tlv_ring_id *ring_id, int ring_id_is_valid,
|
|
enum tlv_vote *vote)
|
|
{
|
|
|
|
if (!ring_id_is_valid) {
|
|
*vote = TLV_VOTE_NO_CHANGE;
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_membership_node_list_reply_received(struct qdevice_net_instance *instance,
|
|
uint32_t seq_number, const struct tlv_ring_id *ring_id, int ring_id_is_valid, enum tlv_vote *vote)
|
|
{
|
|
|
|
if (!ring_id_is_valid) {
|
|
*vote = TLV_VOTE_NO_CHANGE;
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_quorum_node_list_reply_received(struct qdevice_net_instance *instance,
|
|
uint32_t seq_number, const struct tlv_ring_id *ring_id, int ring_id_is_valid, enum tlv_vote *vote)
|
|
{
|
|
|
|
if (!ring_id_is_valid) {
|
|
*vote = TLV_VOTE_NO_CHANGE;
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_ask_for_vote_reply_received(struct qdevice_net_instance *instance,
|
|
uint32_t seq_number, const struct tlv_ring_id *ring_id, int ring_id_is_valid, enum tlv_vote *vote)
|
|
{
|
|
|
|
if (!ring_id_is_valid) {
|
|
*vote = TLV_VOTE_NO_CHANGE;
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_vote_info_received(struct qdevice_net_instance *instance,
|
|
uint32_t seq_number, const struct tlv_ring_id *ring_id, int ring_id_is_valid, enum tlv_vote *vote)
|
|
{
|
|
|
|
if (!ring_id_is_valid) {
|
|
*vote = TLV_VOTE_NO_CHANGE;
|
|
}
|
|
|
|
return (0);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_echo_reply_received(struct qdevice_net_instance *instance,
|
|
uint32_t seq_number, int is_expected_seq_number)
|
|
{
|
|
|
|
return (is_expected_seq_number ? 0 : -1);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_echo_reply_not_received(struct qdevice_net_instance *instance)
|
|
{
|
|
|
|
return (-1);
|
|
}
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_disconnected(struct qdevice_net_instance *instance,
|
|
enum qdevice_net_disconnect_reason disconnect_reason, int *try_reconnect, enum tlv_vote *vote)
|
|
{
|
|
|
|
/*
|
|
* We cannot depend on default behavior (until there is no change -> use old vote).
|
|
* This could create two quorate clusters (2:2 -> first half get ACK -> first half
|
|
* disconnects from qnetd -> second half get ACK -> two quorate clusters)
|
|
*/
|
|
*vote = TLV_VOTE_NACK;
|
|
|
|
return (0);
|
|
}
|
|
|
|
void
|
|
qdevice_net_algo_ffsplit_destroy(struct qdevice_net_instance *instance)
|
|
{
|
|
|
|
}
|
|
|
|
static struct qdevice_net_algorithm qdevice_net_algo_ffsplit = {
|
|
.init = qdevice_net_algo_ffsplit_init,
|
|
.connected = qdevice_net_algo_ffsplit_connected,
|
|
.config_node_list_changed = qdevice_net_algo_ffsplit_config_node_list_changed,
|
|
.votequorum_node_list_notify = qdevice_net_algo_ffsplit_votequorum_node_list_notify,
|
|
.votequorum_quorum_notify = qdevice_net_algo_ffsplit_votequorum_quorum_notify,
|
|
.votequorum_expected_votes_notify = qdevice_net_algo_ffsplit_votequorum_expected_votes_notify,
|
|
.config_node_list_reply_received = qdevice_net_algo_ffsplit_config_node_list_reply_received,
|
|
.membership_node_list_reply_received = qdevice_net_algo_ffsplit_membership_node_list_reply_received,
|
|
.quorum_node_list_reply_received = qdevice_net_algo_ffsplit_quorum_node_list_reply_received,
|
|
.ask_for_vote_reply_received = qdevice_net_algo_ffsplit_ask_for_vote_reply_received,
|
|
.vote_info_received = qdevice_net_algo_ffsplit_vote_info_received,
|
|
.echo_reply_received = qdevice_net_algo_ffsplit_echo_reply_received,
|
|
.echo_reply_not_received = qdevice_net_algo_ffsplit_echo_reply_not_received,
|
|
.disconnected = qdevice_net_algo_ffsplit_disconnected,
|
|
.destroy = qdevice_net_algo_ffsplit_destroy,
|
|
};
|
|
|
|
int
|
|
qdevice_net_algo_ffsplit_register(void)
|
|
{
|
|
return (qdevice_net_algorithm_register(TLV_DECISION_ALGORITHM_TYPE_FFSPLIT, &qdevice_net_algo_ffsplit));
|
|
}
|